Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: Source/bindings/dart/DartUtilities.h

Issue 289083003: [dartium] Dart half of ScriptValue refactoring. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/1916
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartScriptValue.cpp ('k') | Source/bindings/dart/DartUtilities.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartUtilities.h
diff --git a/Source/bindings/dart/DartUtilities.h b/Source/bindings/dart/DartUtilities.h
index 24a7a23ef141a1f05bdcfbb2fb804a8c1ac60f41..b5f4ceb39853bc81df74dec733faac265f9e6d34 100644
--- a/Source/bindings/dart/DartUtilities.h
+++ b/Source/bindings/dart/DartUtilities.h
@@ -37,8 +37,8 @@
#include "DartWebkitClassIds.h"
#include "bindings/common/Dictionary.h"
-#include "bindings/common/ScriptValue.h"
#include "bindings/dart/DartDOMData.h"
+#include "bindings/dart/DartScriptValue.h"
#include "bindings/dart/DartStringCache.h"
#include "bindings/v8/ScriptPromise.h"
#include "bindings/v8/SerializedScriptValue.h"
@@ -518,8 +518,7 @@ public:
// to observe from user code.
static ScriptValue dartToScriptValueWithNullCheck(Dart_Handle handle, Dart_Handle& exception)
{
- v8::Isolate* isolate = v8::Isolate::GetCurrent();
- return Dart_IsNull(handle) ? ScriptValue(v8::Undefined(isolate), isolate) : dartToScriptValue(handle, exception);
+ return dartToScriptValue(handle, exception);
}
static ScriptValue dartToScriptValueWithNullCheck(Dart_NativeArguments args, int index, Dart_Handle& exception)
{
« no previous file with comments | « Source/bindings/dart/DartScriptValue.cpp ('k') | Source/bindings/dart/DartUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698