Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2890733002: Make EBorderStyle an enum class. (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, shend
CC:
darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, cbiesinger, chromium-reviews, dglazkov+blink, dgrogan+ng_chromium.org, dshwang, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EBorderStyle an enum class. This patch makes EBorderStyle an enum class for better type safety. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2890733002 Cr-Commit-Position: refs/heads/master@{#472754} Committed: https://chromium.googlesource.com/chromium/src/+/c68a7332c9f3558c810b0218c8b4853abc93c074

Patch Set 1 #

Patch Set 2 : Build for Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -279 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/CollapsedBorderValue.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/CollapsedBorderValueTest.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 12 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 5 chunks +18 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 17 chunks +65 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 6 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderEdge.cpp View 2 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderStyle.h View 2 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderValue.h View 4 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 14 chunks +36 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 3 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/OutlineValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/OutlineValueTest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleMultiColData.h View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 30 (22 generated)
nainar
shen@, PTAL? Thanks!
3 years, 7 months ago (2017-05-17 08:00:58 UTC) #5
shend
lgtm
3 years, 7 months ago (2017-05-17 08:03:49 UTC) #7
nainar
meade@, PTAL? Thanks!
3 years, 7 months ago (2017-05-17 08:04:59 UTC) #9
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-18 03:29:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890733002/1
3 years, 7 months ago (2017-05-18 03:35:49 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/421955)
3 years, 7 months ago (2017-05-18 03:58:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890733002/20001
3 years, 7 months ago (2017-05-18 09:38:02 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 09:44:06 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c68a7332c9f3558c810b0218c8b4...

Powered by Google App Engine
This is Rietveld 408576698