third_party/WebKit/Source/core/style/ComputedStyleTest.cpp - Issue 2890733002: Make EBorderStyle an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

Issue 2890733002: Make EBorderStyle an enum class. (Closed)

Patch Set: Build for Mac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyleConstants.h ('k') | third_party/WebKit/Source/core/style/OutlineValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp b/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

index 10e0975641ae1f20c9788db0daf98c480fa4e760..392e89efb15b932da72d33dd1af78b9b7ffedf92 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyleTest.cpp

@@ -47,7 +47,7 @@ TEST(ComputedStyleTest, FocusRingWidth) {

RefPtr<ComputedStyle> style = ComputedStyle::Create();

style->SetEffectiveZoom(3.5);

#if OS(MACOSX)

- style->SetOutlineStyle(kBorderStyleSolid);

+ style->SetOutlineStyle(EBorderStyle::kSolid);

ASSERT_EQ(3, style->GetOutlineStrokeWidthForFocusRing());

#else

ASSERT_EQ(3.5, style->GetOutlineStrokeWidthForFocusRing());

@@ -58,7 +58,7 @@ TEST(ComputedStyleTest, FocusRingWidth) {

TEST(ComputedStyleTest, FocusRingOutset) {

RefPtr<ComputedStyle> style = ComputedStyle::Create();

- style->SetOutlineStyle(kBorderStyleSolid);

+ style->SetOutlineStyle(EBorderStyle::kSolid);

style->SetOutlineStyleIsAuto(kOutlineIsAutoOn);

style->SetEffectiveZoom(4.75);

#if OS(MACOSX)

@@ -110,7 +110,7 @@ TEST(CompuetedStyleTest, HasOutlineWithCurrentColor) {

EXPECT_FALSE(style->HasOutlineWithCurrentColor());

style->SetOutlineWidth(5);

EXPECT_FALSE(style->HasOutlineWithCurrentColor());

- style->SetOutlineStyle(kBorderStyleSolid);

+ style->SetOutlineStyle(EBorderStyle::kSolid);

EXPECT_TRUE(style->HasOutlineWithCurrentColor());

}

@@ -121,7 +121,7 @@ TEST(CompuetedStyleTest, HasBorderColorReferencingCurrentColor) {

EXPECT_FALSE(style->HasBorderColorReferencingCurrentColor());

style->SetBorderBottomWidth(5);

EXPECT_FALSE(style->HasBorderColorReferencingCurrentColor());

- style->SetBorderBottomStyle(kBorderStyleSolid);

+ style->SetBorderBottomStyle(EBorderStyle::kSolid);

EXPECT_TRUE(style->HasBorderColorReferencingCurrentColor());

}