third_party/WebKit/Source/core/style/OutlineValue.h - Issue 2890733002: Make EBorderStyle an enum class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/OutlineValue.h

Issue 2890733002: Make EBorderStyle an enum class. (Closed)

Patch Set: Build for Mac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/OutlineValue.h

diff --git a/third_party/WebKit/Source/core/style/OutlineValue.h b/third_party/WebKit/Source/core/style/OutlineValue.h

index 5cbc5aa5d46c726ac9bc2e256debd5e77dfb63e0..82034e6b86d0ed87626c7de17a721278fe4dff68 100644

--- a/third_party/WebKit/Source/core/style/OutlineValue.h

+++ b/third_party/WebKit/Source/core/style/OutlineValue.h

@@ -45,7 +45,8 @@ class OutlineValue final : public BorderValue {

bool operator!=(const OutlineValue& o) const { return !(*this == o); }

bool VisuallyEqual(const OutlineValue& o) const {

- if (style_ == kBorderStyleNone && o.style_ == kBorderStyleNone)

+ if (style_ == static_cast<unsigned>(EBorderStyle::kNone) &&

+ o.style_ == static_cast<unsigned>(EBorderStyle::kNone))

return true;

return *this == o;

}