Issue 2889933003: [PageLoadMetrics] Enable AdsPageLoadMetrics once again

Issue 2889933003: [PageLoadMetrics] Enable AdsPageLoadMetrics once again (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 months, 1 week ago by jkarlin

Modified:
4 months, 1 week ago

Reviewers:
Bryan McQuade

CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

Created: 4 months, 1 week ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Trybot results: linux_chromium_rel_ng win_chromium_rel_ng chromium_presubmit linux_chromium_rel_ng linux_chromium_rel_ng linux_chromium_chromeos_rel_ng win_chromium_x64_rel_ng win_clang win_chromium_rel_ng win_chromium_compile_dbg_ng mac_chromium_compile_dbg_ng mac_chromium_rel_ng ios-simulator-xcode-clang ios-simulator ios-device-xcode-clang ios-device linux_chromium_tsan_rel_ng linux_chromium_rel_ng linux_chromium_compile_dbg_ng linux_chromium_chromeos_rel_ng linux_chromium_chromeos_ozone_rel_ng linux_chromium_asan_rel_ng chromium_presubmit chromeos_daisy_chromium_compile_only_ng cast_shell_linux chromeos_amd64-generic_chromium_compile_only_ng linux_android_rel_ng cast_shell_android android_n5x_swarming_rel android_compile_dbg android_clang_dbg_recipe android_cronet android_arm64_dbg_recipe

Commit queue not available (can’t edit this change).

Depends on Patchset:

Total messages: 18 (14 generated)

jkarlin

bmcquade@ PTAL, the fix is in https://codereview.chromium.org/2893633003/ and this patch depends on it.

4 months, 1 week ago (2017-05-17 18:35:57 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889933003/20001

4 months, 1 week ago (2017-05-18 16:46:46 UTC) #15

commit-bot: I haz the power

4 months, 1 week ago (2017-05-18 17:49:57 UTC) #18

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8...