Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2889933003: [PageLoadMetrics] Enable AdsPageLoadMetrics once again (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by jkarlin
Modified:
4 months, 1 week ago
Reviewers:
Bryan McQuade
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG=708570 Review-Url: https://codereview.chromium.org/2889933003 Cr-Commit-Position: refs/heads/master@{#472866} Committed: https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 18 (14 generated)
jkarlin
bmcquade@ PTAL, the fix is in https://codereview.chromium.org/2893633003/ and this patch depends on it.
4 months, 1 week ago (2017-05-17 18:35:57 UTC) #5
Bryan McQuade
lgtm
4 months, 1 week ago (2017-05-17 22:07:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889933003/20001
4 months, 1 week ago (2017-05-18 16:46:46 UTC) #15
commit-bot: I haz the power
4 months, 1 week ago (2017-05-18 17:49:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b