Chromium Code Reviews
|
|
|
Created:
1 year, 1 month ago by jkarlin Modified:
1 year, 1 month ago Reviewers:
Bryan McQuade CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[PageLoadMetrics] Enable AdsPageLoadMetrics once again
BUG=708570
Review-Url: https://codereview.chromium.org/2889933003
Cr-Commit-Position: refs/heads/master@{#472866}
Committed: https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a
Patch Set 1 #Patch Set 2 : Rebase #
Depends on Patchset: Messages
Total messages: 18 (14 generated)
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Description was changed from ========== [PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG=708570 ========== to ========== [PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG=708570 ==========
jkarlin@chromium.org changed reviewers: + bmcquade@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bmcquade@ PTAL, the fix is in https://codereview.chromium.org/2893633003/ and this patch depends on it.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jkarlin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmcquade@chromium.org Link to the patchset: https://codereview.chromium.org/2889933003/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495125966837230,
"parent_rev": "9d6afd71a4937e9f400609f839c2b39b22c4c497", "commit_rev":
"8dedd689f7ca1b0f4f64d8c238f8b960a3f54a8a"}
Message was sent while issue was closed.
Description was changed from ========== [PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG=708570 ========== to ========== [PageLoadMetrics] Enable AdsPageLoadMetrics once again BUG=708570 Review-Url: https://codereview.chromium.org/2889933003 Cr-Commit-Position: refs/heads/master@{#472866} Committed: https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8dedd689f7ca1b0f4f64d8c238f8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
