Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 2889723002: Mojo JavaScript bindings: follow JavaScript naming rules. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JavaScript bindings: follow JavaScript naming rules. This patch makes sure the following names follows the JavaScript naming rules in the use_new_js_bindings mode: - method names; - parameter names; - struct/union field names; - namespaces. BUG=718614 Review-Url: https://codereview.chromium.org/2889723002 Cr-Original-Commit-Position: refs/heads/master@{#472260} Committed: https://chromium.googlesource.com/chromium/src/+/40b5e68dcd6a93d50931898b2d180195966adac3 Review-Url: https://codereview.chromium.org/2889723002 Cr-Commit-Position: refs/heads/master@{#472541} Committed: https://chromium.googlesource.com/chromium/src/+/c29cc4ea75913bb687853ef0722ca45084c72a61

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -86 lines) Patch
M mojo/public/js/new_bindings/lib/control_message_handler.js View 1 2 2 chunks +25 lines, -25 lines 0 comments Download
M mojo/public/js/new_bindings/lib/control_message_proxy.js View 1 2 5 chunks +18 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 1 10 chunks +51 lines, -40 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 3 chunks +25 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (16 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 7 months ago (2017-05-16 18:18:07 UTC) #6
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-16 18:25:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889723002/20001
3 years, 7 months ago (2017-05-16 18:30:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456457)
3 years, 7 months ago (2017-05-16 22:36:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889723002/20001
3 years, 7 months ago (2017-05-16 22:58:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/40b5e68dcd6a93d50931898b2d180195966adac3
3 years, 7 months ago (2017-05-17 00:20:34 UTC) #17
yzshen1
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2893543002/ by yzshen@chromium.org. ...
3 years, 7 months ago (2017-05-17 05:46:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889723002/40001
3 years, 7 months ago (2017-05-17 17:39:19 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 19:54:39 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c29cc4ea75913bb687853ef0722c...

Powered by Google App Engine
This is Rietveld 408576698