Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2893493002: Mojo JS bindings: update the new bindings with the associated interface feature. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by yzshen1
Modified:
1 week, 2 days ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: update the new bindings with the associated interface feature. This copies the code from the old bindings. The only change is how module loading is done. BUG=699569 R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2893493002 . Cr-Commit-Position: refs/heads/master@{#473311} Committed: https://chromium.googlesource.com/chromium/src/+/28d2a16306ed4423840becef6cfc38ca8763adfb

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1665 lines, -245 lines) Patch
M mojo/public/js/BUILD.gn View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/js/new_bindings/bindings.js View 1 2 14 chunks +319 lines, -37 lines 0 comments Download
M mojo/public/js/new_bindings/codec.js View 16 chunks +243 lines, -21 lines 0 comments Download
M mojo/public/js/new_bindings/connector.js View 1 3 chunks +83 lines, -17 lines 0 comments Download
M mojo/public/js/new_bindings/interface_types.js View 3 chunks +43 lines, -0 lines 0 comments Download
M mojo/public/js/new_bindings/lib/control_message_handler.js View 1 1 chunk +4 lines, -5 lines 0 comments Download
M mojo/public/js/new_bindings/lib/control_message_proxy.js View 1 4 chunks +13 lines, -11 lines 0 comments Download
A mojo/public/js/new_bindings/lib/interface_endpoint_client.js View 1 1 chunk +221 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/lib/interface_endpoint_handle.js View 1 chunk +182 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/lib/pipe_control_message_handler.js View 1 1 chunk +52 lines, -0 lines 0 comments Download
A mojo/public/js/new_bindings/lib/pipe_control_message_proxy.js View 1 1 chunk +50 lines, -0 lines 0 comments Download
M mojo/public/js/new_bindings/router.js View 1 chunk +260 lines, -136 lines 0 comments Download
M mojo/public/js/new_bindings/validator.js View 12 chunks +190 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Dependent Patchsets:

Messages

Total messages: 32 (21 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
1 week, 4 days ago (2017-05-17 18:45:26 UTC) #10
Ken Rockot(use gerrit already)
lgtm
1 week, 3 days ago (2017-05-19 02:28:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893493002/40001
1 week, 2 days ago (2017-05-19 05:04:39 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431516)
1 week, 2 days ago (2017-05-19 07:33:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893493002/40001
1 week, 2 days ago (2017-05-19 07:40:07 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431679)
1 week, 2 days ago (2017-05-19 10:00:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893493002/40001
1 week, 2 days ago (2017-05-19 14:29:40 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/431899)
1 week, 2 days ago (2017-05-19 17:03:34 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893493002/60001
1 week, 2 days ago (2017-05-19 17:21:02 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/432113)
1 week, 2 days ago (2017-05-19 19:41:24 UTC) #30
yzshen1
1 week, 2 days ago (2017-05-19 21:01:06 UTC) #32
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
28d2a16306ed4423840becef6cfc38ca8763adfb (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06