Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2893543002: Revert of Mojo JavaScript bindings: follow JavaScript naming rules. (Closed)

Created:
3 years, 7 months ago by yzshen1
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo JavaScript bindings: follow JavaScript naming rules. (patchset #2 id:20001 of https://codereview.chromium.org/2889723002/ ) Reason for revert: Caused layout tests failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/52495 Original issue's description: > Mojo JavaScript bindings: follow JavaScript naming rules. > > This patch makes sure the following names follows the JavaScript naming rules in the use_new_js_bindings mode: > - method names; > - parameter names; > - struct/union field names; > - namespaces. > > BUG=718614 > > Review-Url: https://codereview.chromium.org/2889723002 > Cr-Commit-Position: refs/heads/master@{#472260} > Committed: https://chromium.googlesource.com/chromium/src/+/40b5e68dcd6a93d50931898b2d180195966adac3 TBR=rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718614 Review-Url: https://codereview.chromium.org/2893543002 Cr-Commit-Position: refs/heads/master@{#472343} Committed: https://chromium.googlesource.com/chromium/src/+/02e69c4cd874078942ece36ee76383c1d6965f4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -76 lines) Patch
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 10 chunks +40 lines, -51 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 3 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
yzshen1
Created Revert of Mojo JavaScript bindings: follow JavaScript naming rules.
3 years, 7 months ago (2017-05-17 05:46:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2893543002/1
3 years, 7 months ago (2017-05-17 05:47:42 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 05:48:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02e69c4cd874078942ece36ee763...

Powered by Google App Engine
This is Rietveld 408576698