Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1030)

Issue 2886793002: diagnose_bloat.py: Don't run git commands when --cloud (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diagnose_bloat.py: Don't run git commands when --cloud And rename .size files to match convention bots are using ("Foo.apk.size") Review-Url: https://codereview.chromium.org/2886793002 Cr-Commit-Position: refs/heads/master@{#472104} Committed: https://chromium.googlesource.com/chromium/src/+/39d901db10bab9871713a467c829df91747057ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/binary_size/diagnose_bloat.py View 2 chunks +7 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
agrieve
On 2017/05/16 14:04:32, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org 🎟
3 years, 7 months ago (2017-05-16 14:04:54 UTC) #3
estevenson
On 2017/05/16 14:04:54, agrieve wrote: > On 2017/05/16 14:04:32, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
3 years, 7 months ago (2017-05-16 14:11:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886793002/1
3 years, 7 months ago (2017-05-16 14:41:38 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 14:52:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/39d901db10bab9871713a467c829...

Powered by Google App Engine
This is Rietveld 408576698