Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2888783002: Update scaling of video layers on every swap. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by jbauman
Modified:
1 month ago
Reviewers:
sunnyps
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update scaling of video layers on every swap. The scale factor can change even if the image itself doesn't change, so the variables need to be updated before that early-out. BUG=654631 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2888783002 Cr-Commit-Position: refs/heads/master@{#473380} Committed: https://chromium.googlesource.com/chromium/src/+/027183a19bdc7fc48d75dd046e9c8ab8be1700d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -31 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 2 chunks +30 lines, -30 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win_unittest.cc View 1 chunk +12 lines, -1 line 0 comments Download
Trybot results:  win_chromium_x64_rel_ng   win_optional_gpu_tests_rel   win_clang   win_chromium_rel_ng   mac_optional_gpu_tests_rel   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   mac_chromium_rel_ng   ios-simulator   ios-device   ios-device-xcode-clang   linux_optional_gpu_tests_rel   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   chromium_presubmit   linux_chromium_asan_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   android_optional_gpu_tests_rel   linux_android_rel_ng   android_n5x_swarming_rel   cast_shell_android   android_compile_dbg   android_clang_dbg_recipe   android_cronet   android_arm64_dbg_recipe   win_chromium_rel_ng   win_chromium_rel_ng   win_optional_gpu_tests_rel   win_clang   win_chromium_x64_rel_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_optional_gpu_tests_rel   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   ios-simulator-xcode-clang   ios-device   ios-device-xcode-clang   linux_optional_gpu_tests_rel   linux_chromium_tsan_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   linux_android_rel_ng   android_optional_gpu_tests_rel   android_cronet   android_n5x_swarming_rel   android_compile_dbg   android_arm64_dbg_recipe   android_clang_dbg_recipe 
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
jbauman
1 month, 1 week ago (2017-05-16 23:50:14 UTC) #5
jbauman
suunyps, ping
1 month ago (2017-05-19 21:49:37 UTC) #8
sunnyps
lgtm
1 month ago (2017-05-19 22:01:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888783002/1
1 month ago (2017-05-19 22:21:16 UTC) #11
commit-bot: I haz the power
1 month ago (2017-05-19 23:12:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/027183a19bdc7fc48d75dd046e9c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318