Slightly modify sizes of overlays that are larger than the monitor

Slightly modify sizes of overlays that are larger than the monitor

Because of the rounding when converting between pixels and DIPs, a
fullscreen video can become slightly larger than the monitor - e.g. on a
3000x2000 monitor with a scale factor of 1.75 a 1920x1079 video can
become 3002x1689.

On older Intel drivers, swapchains that are bigger than the monitor
won't be put into overlays, which will hurt power usage a lot. On those
systems, the scaling can be adjusted very slightly so that it's less
than the monitor size. This should be close to imperceptible.

BUG=720059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884843002
Cr-Commit-Position: refs/heads/master@{#471989}
Committed: https://chromium.googlesource.com/chromium/src/+/2c74298547fc78cca48b66e917e0983dedacdbb4

[jbauman, 2017-05-15 22:03:28]

Description was changed from

==========
Slightly modify sizes of overlays that are larger than the monitor

Because of the rounding when converting between pixels and DIPs, a
fullscreen video can become slightly larger than the monitor - e.g. on a
3000x2000 monitor with a scale factor of 1.75 a 1920x1079 video can
become 3002x1689.

On older Intel drivers, swapchains that are bigger than the monitor
won't be put into overlays, which will hurt power usage a lot. On those
systems, the scaling can be adjusted very slightly so that it's less
than the monitor size. This should be close to imperceptible.

BUG=720059
==========

to

==========
Slightly modify sizes of overlays that are larger than the monitor

Because of the rounding when converting between pixels and DIPs, a
fullscreen video can become slightly larger than the monitor - e.g. on a
3000x2000 monitor with a scale factor of 1.75 a 1920x1079 video can
become 3002x1689.

On older Intel drivers, swapchains that are bigger than the monitor
won't be put into overlays, which will hurt power usage a lot. On those
systems, the scaling can be adjusted very slightly so that it's less
than the monitor size. This should be close to imperceptible.

BUG=720059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-05-15 22:03:34]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 22:06:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-05-15 23:48:49]

jbauman@chromium.org changed reviewers:
+ sunnyps@chromium.org

[sunnyps, 2017-05-16 00:00:44]

lgtm

https://codereview.chromium.org/2884843002/diff/1/gpu/ipc/service/direct_comp...
File gpu/ipc/service/direct_composition_surface_win.cc (right):

https://codereview.chromium.org/2884843002/diff/1/gpu/ipc/service/direct_comp...
gpu/ipc/service/direct_composition_surface_win.cc:655: if ((bounds_rect.x() >=
0) &&
nit: what's the reason for the x/y checks? instead of just checking
width/height?

[jbauman, 2017-05-16 00:04:53]

On 2017/05/16 00:00:44, sunnyps wrote:
> lgtm
> 
>
https://codereview.chromium.org/2884843002/diff/1/gpu/ipc/service/direct_comp...
> File gpu/ipc/service/direct_composition_surface_win.cc (right):
> 
>
https://codereview.chromium.org/2884843002/diff/1/gpu/ipc/service/direct_comp...
> gpu/ipc/service/direct_composition_surface_win.cc:655: if ((bounds_rect.x() >=
> 0) &&
> nit: what's the reason for the x/y checks? instead of just checking
> width/height?

Basically, I want to check that the area that is going to be uncovered by the
change in size is most likely to be invisible offscreen, rather than visible
because the x or y offset is negative.

[jbauman, 2017-05-16 02:08:19]

The CQ bit was unchecked by jbauman@chromium.org

[jbauman, 2017-05-16 02:08:23]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:08:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:36:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494900503223450, "parent_rev":
"f8bffd21cd88841f6f8427b117f023ebd93f6259", "commit_rev":
"2c74298547fc78cca48b66e917e0983dedacdbb4"}

[commit-bot: I haz the power, 2017-05-16 02:36:40]

Description was changed from

==========
Slightly modify sizes of overlays that are larger than the monitor

Because of the rounding when converting between pixels and DIPs, a
fullscreen video can become slightly larger than the monitor - e.g. on a
3000x2000 monitor with a scale factor of 1.75 a 1920x1079 video can
become 3002x1689.

On older Intel drivers, swapchains that are bigger than the monitor
won't be put into overlays, which will hurt power usage a lot. On those
systems, the scaling can be adjusted very slightly so that it's less
than the monitor size. This should be close to imperceptible.

BUG=720059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Slightly modify sizes of overlays that are larger than the monitor

Because of the rounding when converting between pixels and DIPs, a
fullscreen video can become slightly larger than the monitor - e.g. on a
3000x2000 monitor with a scale factor of 1.75 a 1920x1079 video can
become 3002x1689.

On older Intel drivers, swapchains that are bigger than the monitor
won't be put into overlays, which will hurt power usage a lot. On those
systems, the scaling can be adjusted very slightly so that it's less
than the monitor size. This should be close to imperceptible.

BUG=720059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2884843002
Cr-Commit-Position: refs/heads/master@{#471989}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c74298547fc78cca48b66e917e0...
==========

[commit-bot: I haz the power, 2017-05-16 02:36:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2c74298547fc78cca48b66e917e0...