Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2888713003:
Add //build/config:exe_and_shlib_deps (Closed)
|
Created:
3 years, 7 months ago by Tom Anderson Modified:
3 years, 7 months ago CC:
chromium-reviews, Nico, brettw Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd //build/config:exe_and_shlib_deps
This CL adds a new target that all executables and shared libraries
should depend on in preparation for adding a dependency on libc++. It
also changes "component" to reference this new target instead of
//build/config/sanitizers:deps.
BUG=723069
R=dpranke@chromium.org,thakis@chromium.org,brettw@chromium.org
Review-Url: https://codereview.chromium.org/2888713003
Cr-Commit-Position: refs/heads/master@{#472940}
Committed: https://chromium.googlesource.com/chromium/src/+/1334d4270679548dba126bca749e54bb4232310a
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 35 (25 generated)
Description was changed from ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=brettw@chromium.org CC=thakis@chromium.org,dpranke@chromium.org ========== to ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org CC=thakis@chromium.org,brettw@chromium.org ==========
thomasanderson@chromium.org changed reviewers: + dpranke@chromium.org - brettw@chromium.org
dpranke@ ptal I believe we're still undecided about the naming, but I want to make sure it's right before updating 100 targets :S
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + thakis@chromium.org
lgtm, name works for me
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org CC=thakis@chromium.org,brettw@chromium.org ========== to ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org,thakis@chromium.org TBR=brettw@chromium.org ==========
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thomasanderson@chromium.org
thomasanderson@chromium.org changed reviewers: + brettw@chromium.org
+brettw for BUILDCONFIG.gn approval
Description was changed from ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org,thakis@chromium.org TBR=brettw@chromium.org ========== to ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org,thakis@chromium.org,brettw@chromium.org ==========
lgtm
The CQ bit was checked by thomasanderson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495135171420130, "parent_rev":
"656b9cae0b536ee2f9b8a2777f76ba4a4d775173", "commit_rev":
"1334d4270679548dba126bca749e54bb4232310a"}
Message was sent while issue was closed.
Description was changed from ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org,thakis@chromium.org,brettw@chromium.org ========== to ========== Add //build/config:exe_and_shlib_deps This CL adds a new target that all executables and shared libraries should depend on in preparation for adding a dependency on libc++. It also changes "component" to reference this new target instead of //build/config/sanitizers:deps. BUG=723069 R=dpranke@chromium.org,thakis@chromium.org,brettw@chromium.org Review-Url: https://codereview.chromium.org/2888713003 Cr-Commit-Position: refs/heads/master@{#472940} Committed: https://chromium.googlesource.com/chromium/src/+/1334d4270679548dba126bca749e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1334d4270679548dba126bca749e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
