Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2886963002: diagnose_bloat: Remove period in "See detailed diff" message (Closed)

Created:
3 years, 7 months ago by agrieve
Modified:
3 years, 7 months ago
Reviewers:
estevenson
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diagnose_bloat: Remove period in "See detailed diff" message It caused double-click-copy to copy the path along with the period. TBR=estevenson Review-Url: https://codereview.chromium.org/2886963002 Cr-Commit-Position: refs/heads/master@{#472291} Committed: https://chromium.googlesource.com/chromium/src/+/fe4379522ce8a2a2101f8abcf25a1ab3df3f8212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/binary_size/diagnose_bloat.py View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886963002/1
3 years, 7 months ago (2017-05-17 00:34:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fe4379522ce8a2a2101f8abcf25a1ab3df3f8212
3 years, 7 months ago (2017-05-17 02:36:20 UTC) #9
estevenson
3 years, 7 months ago (2017-05-17 14:09:40 UTC) #10
Message was sent while issue was closed.
On 2017/05/17 02:36:20, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/fe4379522ce8a2a2101f8abcf25a...

lgtm

Powered by Google App Engine
This is Rietveld 408576698