Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2888643004: [LayoutNG] Implement LayoutBR/preserved newlines and tabs (Closed)

Created:
3 years, 7 months ago by kojii
Modified:
3 years, 7 months ago
Reviewers:
eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Implement LayoutBR/preserved newlines and tabs This patch implements laying out preserved newlines and tabs. With the control NGInlineItem[1], LayoutBR is also supported. 6 existing tests pass, but 3 of them dumps text, and the text fails to match because innerText ignores blank lines, probably because LayoutNG creates InlineBoxes differently. This is to be investigated. [1] https://codereview.chromium.org/2870413005 BUG=636993 Review-Url: https://codereview.chromium.org/2888643004 Cr-Commit-Position: refs/heads/master@{#474573} Committed: https://chromium.googlesource.com/chromium/src/+/6f0296f4db2b403980ea251a5c720c99d7261e6c

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : #

Patch Set 4 : Cleanup #

Patch Set 5 : Cleanup #

Patch Set 6 : Rebase #

Messages

Total messages: 40 (34 generated)
kojii
PTAL.
3 years, 7 months ago (2017-05-17 20:19:33 UTC) #10
eae
LGTM!
3 years, 7 months ago (2017-05-24 16:44:47 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888643004/120001
3 years, 7 months ago (2017-05-24 16:48:57 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_layout_ng/builds/241)
3 years, 7 months ago (2017-05-25 00:55:11 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888643004/120001
3 years, 7 months ago (2017-05-25 05:46:12 UTC) #37
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 05:51:23 UTC) #40
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/6f0296f4db2b403980ea251a5c72...

Powered by Google App Engine
This is Rietveld 408576698