[LayoutNG] Add "Control" NGInlineItemType for newlines and tabs

[LayoutNG] Add "Control" NGInlineItemType for newlines and tabs

This patch changes preserved newlines and tabs to create separate
NGInlineItem with kControl type.

These control characters need separate code path to measure and to break
lines. Having separate NGInlineItem helps doing them easier.

Also supports LayoutBR, which does not set to preserve newlines in
style.

In doing so, the complexity of conditional branches in a loop was
increased that preserving spaces and preserving newlines got their own
loops.

BUG=636993
Review-Url: https://codereview.chromium.org/2870413005
Cr-Commit-Position: refs/heads/master@{#471333}
Committed: https://chromium.googlesource.com/chromium/src/+/43d6ef93d6c8b62d4b2f09b906268aa7440ca8c1

[kojii, 2017-05-11 21:45:08]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 21:45:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 00:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 00:08:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2017-05-12 07:52:41]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 07:53:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-12 08:09:28]

Description was changed from

==========
ngbr

BUG=
==========

to

==========
[LayoutNG] Add "Control" NGInlineItemType for newlines and tabs

This patch changes preserved newlines and tabs to create separate
NGInlineItem with kControl type.

These control characters need separate code path to measure and to break
lines. Having separate NGInlineItem helps doing them easier.

Also supports LayoutBR, which does not set to preserve newlines in
style.

In doing so, the complexity of conditional branches in a loop was
increased that preserving spaces and preserving newlines got their own
loops.

BUG=636993
==========

[kojii, 2017-05-12 11:01:52]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-05-12 11:01:53]

PTAL. WDYT? I preferred separate loops than many if's in a loop, but wonder it
may be subjective.

[commit-bot: I haz the power, 2017-05-12 11:15:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 11:15:35]

Dry run: This issue passed the CQ dry run.

[eae, 2017-05-12 16:34:50]

OK, LGTM

[eae, 2017-05-12 16:35:21]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-05-12 16:36:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 16:41:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494606921385020,
"parent_rev": "17e05472ffb707c0b92cd3fb69e92434f1993578", "commit_rev":
"43d6ef93d6c8b62d4b2f09b906268aa7440ca8c1"}

[commit-bot: I haz the power, 2017-05-12 16:42:07]

Description was changed from

==========
[LayoutNG] Add "Control" NGInlineItemType for newlines and tabs

This patch changes preserved newlines and tabs to create separate
NGInlineItem with kControl type.

These control characters need separate code path to measure and to break
lines. Having separate NGInlineItem helps doing them easier.

Also supports LayoutBR, which does not set to preserve newlines in
style.

In doing so, the complexity of conditional branches in a loop was
increased that preserving spaces and preserving newlines got their own
loops.

BUG=636993
==========

to

==========
[LayoutNG] Add "Control" NGInlineItemType for newlines and tabs

This patch changes preserved newlines and tabs to create separate
NGInlineItem with kControl type.

These control characters need separate code path to measure and to break
lines. Having separate NGInlineItem helps doing them easier.

Also supports LayoutBR, which does not set to preserve newlines in
style.

In doing so, the complexity of conditional branches in a loop was
increased that preserving spaces and preserving newlines got their own
loops.

BUG=636993

Review-Url: https://codereview.chromium.org/2870413005
Cr-Commit-Position: refs/heads/master@{#471333}
Committed:
https://chromium.googlesource.com/chromium/src/+/43d6ef93d6c8b62d4b2f09b90626...
==========

[commit-bot: I haz the power, 2017-05-12 16:42:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/43d6ef93d6c8b62d4b2f09b90626...