third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc - Issue 2888643004: [LayoutNG] Implement LayoutBR/preserved newlines and tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

Issue 2888643004: [LayoutNG] Implement LayoutBR/preserved newlines and tabs (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

index cb4ab397cd2e4289945ed3617d16e58611afb18b..f4ab00e5b7df4af19d855a6b4d1cd947aae8a74c 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

@@ -310,7 +310,8 @@ void NGInlineNode::CopyFragmentDataToLayoutBox(

const auto* text_fragment = ToNGPhysicalTextFragment(line_child.Get());

const NGInlineItem& item = items[text_fragment->ItemIndex()];

BidiRun* run;

- if (item.Type() == NGInlineItem::kText) {

+ if (item.Type() == NGInlineItem::kText ||

+ item.Type() == NGInlineItem::kControl) {

LayoutObject* layout_object = item.GetLayoutObject();

DCHECK(layout_object->IsText());

unsigned text_offset = text_offsets[text_fragment->ItemIndex()];