Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2888243002: Remove scroll_clip_layer dependency from LayerTreeImpl::ScrollableSize (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 8faee1546b6f7e27f42e5833a0f4dd242d56ca7f..62e9349178b687b328ee201efe00d1304ff7862c 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -1230,17 +1230,21 @@ const Region& LayerTreeImpl::UnoccludedScreenSpaceRegion() const {
}
gfx::SizeF LayerTreeImpl::ScrollableSize() const {
- LayerImpl* root_scroll_layer = OuterViewportScrollLayer()
- ? OuterViewportScrollLayer()
- : InnerViewportScrollLayer();
- if (!root_scroll_layer)
+ LayerImpl* root_scroll_layer = nullptr;
+ LayerImpl* root_container_layer = nullptr;
+ if (OuterViewportScrollLayer()) {
+ root_scroll_layer = OuterViewportScrollLayer();
+ root_container_layer = OuterViewportContainerLayer();
+ } else if (InnerViewportScrollLayer()) {
+ root_scroll_layer = InnerViewportScrollLayer();
+ root_container_layer = InnerViewportContainerLayer();
+ }
+
+ if (!root_scroll_layer || !root_container_layer)
return gfx::SizeF();
gfx::SizeF content_size = root_scroll_layer->BoundsForScrolling();
- gfx::SizeF viewport_size =
- root_scroll_layer->scroll_clip_layer()->BoundsForScrolling();
-
- content_size.SetToMax(viewport_size);
+ content_size.SetToMax(root_container_layer->BoundsForScrolling());
return content_size;
}
« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698