Consolidate the update_client serialization code.

Consolidate the update_client serialization code.

This is a mechanical change.

BUG=687231
Review-Url: https://codereview.chromium.org/2888183003
Cr-Commit-Position: refs/heads/master@{#472713}
Committed: https://chromium.googlesource.com/chromium/src/+/ae0464f478569374e73649576a3171d3491ed325

[Sorin Jianu, 2017-05-17 23:22:33]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org

[Sorin Jianu, 2017-05-17 23:22:33]

PTALTY!

[waffles, 2017-05-17 23:58:05]

lgtm

https://codereview.chromium.org/2888183003/diff/20001/components/update_clien...
File components/update_client/protocol_builder.h (right):

https://codereview.chromium.org/2888183003/diff/20001/components/update_clien...
components/update_client/protocol_builder.h:43: // Builds a ping request for the
specified component.
Worth documenting what "an event ping request element looks like..." as is done
for the other functions here?

https://codereview.chromium.org/2888183003/diff/20001/components/update_clien...
components/update_client/protocol_builder.h:44: std::string BuildPing(const
Configurator& config, const Component& component);
BuildPingRequest to match BuildUpdateCheckRequest?

Or, since I always get tripped up that "BuildPing" does not create a <ping>
(instead an <app> with an <event>), maybe BuildEventPingRequest?

[Sorin Jianu, 2017-05-18 00:25:09]

PTAL!

https://codereview.chromium.org/2888183003/diff/20001/components/update_clien...
File components/update_client/protocol_builder.h (right):

https://codereview.chromium.org/2888183003/diff/20001/components/update_clien...
components/update_client/protocol_builder.h:43: // Builds a ping request for the
specified component.
On 2017/05/17 23:58:05, waffles wrote:
> Worth documenting what "an event ping request element looks like..." as is
done
> for the other functions here?

Done.

https://codereview.chromium.org/2888183003/diff/20001/components/update_clien...
components/update_client/protocol_builder.h:44: std::string BuildPing(const
Configurator& config, const Component& component);
On 2017/05/17 23:58:05, waffles wrote:
> BuildPingRequest to match BuildUpdateCheckRequest?
> 
> Or, since I always get tripped up that "BuildPing" does not create a <ping>
> (instead an <app> with an <event>), maybe BuildEventPingRequest?

Done.

[waffles, 2017-05-18 00:28:00]

lgtm thank you!

[Sorin Jianu, 2017-05-18 00:30:19]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:32:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 01:36:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:36:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sorin Jianu, 2017-05-18 01:36:42]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:38:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:43:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495071402979310,
"parent_rev": "77cd7e79cf24ddef0c1a40c3f5497eb125432aee", "commit_rev":
"ae0464f478569374e73649576a3171d3491ed325"}

[commit-bot: I haz the power, 2017-05-18 06:43:41]

Description was changed from

==========
Consolidate the update_client serialization code.

This is a mechanical change.

BUG=687231
==========

to

==========
Consolidate the update_client serialization code.

This is a mechanical change.

BUG=687231

Review-Url: https://codereview.chromium.org/2888183003
Cr-Commit-Position: refs/heads/master@{#472713}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae0464f478569374e73649576a31...
==========

[commit-bot: I haz the power, 2017-05-18 06:43:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ae0464f478569374e73649576a31...