components/update_client/ping_manager.cc - Issue 2888183003: Consolidate the update_client serialization code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/ping_manager.cc

Issue 2888183003: Consolidate the update_client serialization code. (Closed)

Patch Set: wip Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/update_client/ping_manager.cc

diff --git a/components/update_client/ping_manager.cc b/components/update_client/ping_manager.cc

index 121d7117895d875137d3cfdb0282846b14024ee7..66d9e2b970c41ca99bad61d8d343b4e5cea7c1fa 100644

--- a/components/update_client/ping_manager.cc

+++ b/components/update_client/ping_manager.cc

@@ -67,6 +67,9 @@ void PingSender::OnRequestSenderComplete(int error,

bool PingSender::SendPing(const Component& component) {

DCHECK(thread_checker_.CalledOnValidThread());

+ if (component.events().empty())

+ return false;

auto urls(config_->PingUrl());

if (component.crx_component().requires_network_encryption)

RemoveUnsecureUrls(&urls);