Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: components/update_client/update_engine.cc

Issue 2888183003: Consolidate the update_client serialization code. (Closed)
Patch Set: wip Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/update_client/protocol_builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/update_engine.cc
diff --git a/components/update_client/update_engine.cc b/components/update_client/update_engine.cc
index f56793f78bd9a1c99cf5737d061a52213ff89418..ef4db8eaf93886b46fd6c158768076d1899d6248 100644
--- a/components/update_client/update_engine.cc
+++ b/components/update_client/update_engine.cc
@@ -285,8 +285,7 @@ void UpdateEngine::HandleComponentComplete(const UpdateContextIterator& it) {
if (component->IsHandled()) {
(*it)->next_update_delay = component->GetUpdateDuration();
- // Only ping when the server response included an update for this component.
- if (component->CanPing()) {
+ if (!component->events().empty()) {
ping_manager_->SendPing(*component);
}
« no previous file with comments | « components/update_client/protocol_builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698