Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
index b74b869b398b0a39980e32d736241238686a0b82..9ef69df9fc7a623849b6d5903597422565eb2f86 100644
--- a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
+++ b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc
@@ -72,7 +72,7 @@ class MockSyncWebSocket : public SyncWebSocket {
response.SetInteger("id", id_);
base::DictionaryValue result;
result.SetInteger("param", 1);
- response.Set("result", result.DeepCopy());
+ response.Set("result", base::MakeUnique<base::Value>(result));
base::JSONWriter::Write(response, message);
--queued_messages_;
return SyncWebSocket::kOk;
@@ -726,7 +726,7 @@ class OnConnectedSyncWebSocket : public SyncWebSocket {
base::DictionaryValue response;
response.SetInteger("id", id);
- response.Set("result", new base::DictionaryValue());
+ response.Set("result", base::MakeUnique<base::DictionaryValue>());
std::string json_response;
base::JSONWriter::Write(response, &json_response);
queued_response_.push_back(json_response);
@@ -734,7 +734,7 @@ class OnConnectedSyncWebSocket : public SyncWebSocket {
// Push one event.
base::DictionaryValue event;
event.SetString("method", "updateEvent");
- event.Set("params", new base::DictionaryValue());
+ event.Set("params", base::MakeUnique<base::DictionaryValue>());
std::string json_event;
base::JSONWriter::Write(event, &json_event);
queued_response_.push_back(json_event);
@@ -1148,7 +1148,7 @@ class MockSyncWebSocket7 : public SyncWebSocket {
response.SetInteger("id", 2);
base::DictionaryValue result;
result.SetInteger("param", 1);
- response.Set("result", result.DeepCopy());
+ response.Set("result", base::MakeUnique<base::Value>(result));
base::JSONWriter::Write(response, message);
sent_responses_++;
return SyncWebSocket::kOk;

Powered by Google App Engine
This is Rietveld 408576698