Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_client_impl.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.cc b/chrome/test/chromedriver/chrome/devtools_client_impl.cc
index f814d2432f2c2813ccf8ebb4beb7dabbf73668dc..af6ef73cc18464f9182f52bb1c680786b8948e53 100644
--- a/chrome/test/chromedriver/chrome/devtools_client_impl.cc
+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.cc
@@ -10,6 +10,7 @@
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
@@ -268,7 +269,7 @@ Status DevToolsClientImpl::SendCommandInternal(
base::DictionaryValue command;
command.SetInteger("id", command_id);
command.SetString("method", method);
- command.Set("params", params.DeepCopy());
+ command.Set("params", base::MakeUnique<base::Value>(params));
std::string message = SerializeValue(&command);
if (IsVLogOn(1)) {
VLOG(1) << "DEVTOOLS COMMAND " << method << " (id=" << command_id << ") "

Powered by Google App Engine
This is Rietveld 408576698