Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: chrome/browser/prerender/prerender_history.h

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_history.h
diff --git a/chrome/browser/prerender/prerender_history.h b/chrome/browser/prerender/prerender_history.h
index 1ace14df5790cb7bb8e7acf93abf3ab3dbd4e8de..8418fb3687fec3904ad4d4b493bea7e6f776228c 100644
--- a/chrome/browser/prerender/prerender_history.h
+++ b/chrome/browser/prerender/prerender_history.h
@@ -68,7 +68,7 @@ class PrerenderHistory : public base::NonThreadSafe {
void Clear();
// Retrieves the entries as a value which can be displayed.
- base::Value* GetEntriesAsValue() const;
+ std::unique_ptr<base::Value> GetEntriesAsValue() const;
Nico 2017/05/17 15:43:10 Huh, having a function starting Get... transfer ow
jdoerrie 2017/05/17 16:23:54 Done: https://codereview.chromium.org/2893653002
private:
std::list<Entry> entries_;
« no previous file with comments | « chrome/browser/policy/test/local_policy_test_server.cc ('k') | chrome/browser/prerender/prerender_history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698