Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3383)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/prerender/prerender_history.h ('K') | « chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc ('k') | chrome/test/chromedriver/chrome_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index bc80f1da416fecbc9ced40f88b46e05a5177e287..ef4aee96b955b6596035f7d468d08c7fb1977d27 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -556,7 +556,7 @@ Status WebViewImpl::SetFileInputFiles(
return Status(kUnknownError, "no node ID for file input");
base::DictionaryValue params;
params.SetInteger("nodeId", node_id);
- params.Set("files", file_list.DeepCopy());
+ params.Set("files", base::MakeUnique<base::Value>(file_list));
return client_->SendCommand("DOM.setFileInputFiles", params);
}
« chrome/browser/prerender/prerender_history.h ('K') | « chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc ('k') | chrome/test/chromedriver/chrome_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698