Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3982)

Unified Diff: chrome/common/extensions/sync_type_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/sync_type_unittest.cc
diff --git a/chrome/common/extensions/sync_type_unittest.cc b/chrome/common/extensions/sync_type_unittest.cc
index b2fbaa4c431b8753d6f87da4d9619bb38feff754..811cef0f6ce70a9178769cbadea5497c2f353fcb 100644
--- a/chrome/common/extensions/sync_type_unittest.cc
+++ b/chrome/common/extensions/sync_type_unittest.cc
@@ -6,6 +6,7 @@
#include "base/files/file_path.h"
#include "base/memory/ptr_util.h"
+#include "base/values.h"
#include "build/build_config.h"
#include "chrome/common/extensions/sync_helper.h"
#include "extensions/common/error_utils.h"
@@ -47,7 +48,7 @@ class ExtensionSyncTypeTest : public testing::Test {
if (type == APP)
source.SetString(keys::kApp, "true");
if (type == THEME)
- source.Set(keys::kTheme, new base::DictionaryValue());
+ source.Set(keys::kTheme, base::MakeUnique<base::DictionaryValue>());
if (!update_url.is_empty()) {
source.SetString(keys::kUpdateURL, update_url.spec());
}
@@ -57,19 +58,19 @@ class ExtensionSyncTypeTest : public testing::Test {
if (type != THEME) {
source.SetBoolean(keys::kConvertedFromUserScript, type == USER_SCRIPT);
if (num_plugins >= 0) {
- base::ListValue* plugins = new base::ListValue();
+ auto plugins = base::MakeUnique<base::ListValue>();
for (int i = 0; i < num_plugins; ++i) {
auto plugin = base::MakeUnique<base::DictionaryValue>();
plugin->SetString(keys::kPluginsPath, std::string());
plugins->Set(i, std::move(plugin));
}
- source.Set(keys::kPlugins, plugins);
+ source.Set(keys::kPlugins, std::move(plugins));
}
}
if (has_plugin_permission) {
- base::ListValue* plugins = new base::ListValue();
+ auto plugins = base::MakeUnique<base::ListValue>();
plugins->Set(0, base::MakeUnique<base::Value>("plugin"));
- source.Set(keys::kPermissions, plugins);
+ source.Set(keys::kPermissions, std::move(plugins));
}
std::string error;

Powered by Google App Engine
This is Rietveld 408576698