Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5386)

Unified Diff: chrome/renderer/chrome_content_renderer_client_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client_unittest.cc
diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc
index 0a133229303988bfc7cc8ff090527439f86f24cb..d8b7f31ad111d691bfc036189b66a62c10016232 100644
--- a/chrome/renderer/chrome_content_renderer_client_unittest.cc
+++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc
@@ -8,11 +8,14 @@
#include <map>
#include <string>
+#include <utility>
#include <vector>
+#include "base/memory/ptr_util.h"
#include "base/metrics/histogram_samples.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/histogram_tester.h"
+#include "base/values.h"
#include "build/build_config.h"
#include "chrome/renderer/searchbox/search_bouncer.h"
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
@@ -114,9 +117,9 @@ scoped_refptr<const extensions::Extension> CreateTestExtension(
manifest.SetString("version", "1");
manifest.SetInteger("manifest_version", 2);
if (is_hosted_app) {
- base::ListValue* url_list = new base::ListValue();
+ auto url_list = base::MakeUnique<base::ListValue>();
url_list->AppendString(app_url);
- manifest.Set(extensions::manifest_keys::kWebURLs, url_list);
+ manifest.Set(extensions::manifest_keys::kWebURLs, std::move(url_list));
manifest.SetString(extensions::manifest_keys::kLaunchWebURL, app_url);
}
std::string error;

Powered by Google App Engine
This is Rietveld 408576698