Remove raw DictionaryValue::Set in //chrome

chrome/common/extensions/sync_type_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
+#include "base/values.h"
 #include "build/build_config.h"
 #include "chrome/common/extensions/sync_helper.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/features/simple_feature.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_handlers/plugins_handler.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
@@ skipping 21 matching lines @@
       int creation_flags,
       int num_plugins,
       bool has_plugin_permission,
       const std::string& expected_error) {
     base::DictionaryValue source;
     source.SetString(keys::kName, "PossiblySyncableExtension");
     source.SetString(keys::kVersion, "0.0.0.0");
     if (type == APP)
       source.SetString(keys::kApp, "true");
     if (type == THEME)
-      source.Set(keys::kTheme, new base::DictionaryValue());
+      source.Set(keys::kTheme, base::MakeUnique<base::DictionaryValue>());
     if (!update_url.is_empty()) {
       source.SetString(keys::kUpdateURL, update_url.spec());
     }
     if (!launch_url.is_empty()) {
       source.SetString(keys::kLaunchWebURL, launch_url.spec());
     }
     if (type != THEME) {
       source.SetBoolean(keys::kConvertedFromUserScript, type == USER_SCRIPT);
       if (num_plugins >= 0) {
-        base::ListValue* plugins = new base::ListValue();
+        auto plugins = base::MakeUnique<base::ListValue>();
         for (int i = 0; i < num_plugins; ++i) {
           auto plugin = base::MakeUnique<base::DictionaryValue>();
           plugin->SetString(keys::kPluginsPath, std::string());
           plugins->Set(i, std::move(plugin));
         }
-        source.Set(keys::kPlugins, plugins);
+        source.Set(keys::kPlugins, std::move(plugins));
       }
     }
     if (has_plugin_permission) {
-      base::ListValue* plugins = new base::ListValue();
+      auto plugins = base::MakeUnique<base::ListValue>();
       plugins->Set(0, base::MakeUnique<base::Value>("plugin"));
-      source.Set(keys::kPermissions, plugins);
+      source.Set(keys::kPermissions, std::move(plugins));
     }
 
     std::string error;
     scoped_refptr<Extension> extension = Extension::Create(
         extension_path, location, source, creation_flags, &error);
     if (expected_error.empty())
       EXPECT_TRUE(extension.get());
     else
       EXPECT_FALSE(extension.get());
     EXPECT_EQ(expected_error, error);
@@ skipping 228 matching lines @@
           EXTENSION, GURL(), GURL(),
           Manifest::INTERNAL, base::FilePath(),
           Extension::NO_FLAGS, 0, true,
           ErrorUtils::FormatErrorMessage(
               errors::kPermissionNotAllowedInManifest, "plugin")));
 }
 
 #endif // !defined(OS_CHROMEOS)
 
 }  // namespace extensions