Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
index 53ab8623c0db4f2431266261af39aed566c8fb57..06ccafb23bde94c987b47ce42b9374090af4e97d 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc
@@ -124,13 +124,12 @@ TEST_F(PlatformAppsManifestTest, CertainApisRequirePlatformApps) {
std::vector<std::unique_ptr<ManifestData>> manifests;
// Create each manifest.
for (const char* api_name : kPlatformAppExperimentalApis) {
- // DictionaryValue will take ownership of this ListValue.
- base::ListValue *permissions = new base::ListValue();
+ auto permissions = base::MakeUnique<base::ListValue>();
permissions->AppendString("experimental");
permissions->AppendString(api_name);
- manifest->Set("permissions", permissions);
- manifests.push_back(
- base::MakeUnique<ManifestData>(manifest->CreateDeepCopy(), ""));
+ manifest->Set("permissions", std::move(permissions));
+ manifests.push_back(base::MakeUnique<ManifestData>(
+ base::MakeUnique<base::DictionaryValue>(*manifest), ""));
}
// First try to load without any flags. This should warn for every API.
for (const std::unique_ptr<ManifestData>& manifest : manifests) {

Powered by Google App Engine
This is Rietveld 408576698