Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
index daa5bf3e3966d98bb48f3f8621ea997fa9ed8672..7978489684cb41b137802482ceaca7e72b32ac02 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc
@@ -4,6 +4,10 @@
#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
+#include <utility>
+
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
#include "extensions/common/manifest_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -14,9 +18,9 @@ TEST_F(ChromeManifestTest, StorageAPIManifestVersionAvailability) {
{
base_manifest.SetString(keys::kName, "test");
base_manifest.SetString(keys::kVersion, "0.1");
- base::ListValue* permissions = new base::ListValue();
+ auto permissions = base::MakeUnique<base::ListValue>();
permissions->AppendString("storage");
- base_manifest.Set(keys::kPermissions, permissions);
+ base_manifest.Set(keys::kPermissions, std::move(permissions));
}
std::string kManifestVersionError =

Powered by Google App Engine
This is Rietveld 408576698