Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4588)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
index 0fba6327586b8fa7d248347ff26e60700ebc4686..ad7212480570efc1c67bbace810167d649089888 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc
@@ -3,8 +3,10 @@
// found in the LICENSE file.
#include <memory>
+#include <utility>
#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
#include "components/version_info/version_info.h"
@@ -102,9 +104,9 @@ TEST_F(ExtensionManifestBackgroundTest, BackgroundPageWebRequest) {
ASSERT_TRUE(extension.get());
EXPECT_TRUE(BackgroundInfo::HasLazyBackgroundPage(extension.get()));
- base::ListValue* permissions = new base::ListValue();
+ auto permissions = base::MakeUnique<base::ListValue>();
permissions->AppendString("webRequest");
- manifest->Set(keys::kPermissions, permissions);
+ manifest->Set(keys::kPermissions, std::move(permissions));
LoadAndExpectError(ManifestData(manifest.get(), ""),
errors::kWebRequestConflictsWithLazyBackground);
}

Powered by Google App Engine
This is Rietveld 408576698