Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: chrome/browser/ui/webui/sync_internals_message_handler.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/sync_internals_message_handler.cc b/chrome/browser/ui/webui/sync_internals_message_handler.cc
index eab283ce9c0900b839ff0dc880bc56ffa0c1c0f0..4e29f99aa8637096092f329813a2d08459577e35 100644
--- a/chrome/browser/ui/webui/sync_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/sync_internals_message_handler.cc
@@ -144,7 +144,7 @@ void SyncInternalsMessageHandler::HandleRequestListOfTypes(
it.Good(); it.Inc()) {
type_list->AppendString(ModelTypeToString(it.Get()));
}
- event_details.Set(syncer::sync_ui_util::kTypes, type_list.release());
+ event_details.Set(syncer::sync_ui_util::kTypes, std::move(type_list));
web_ui()->CallJavascriptFunctionUnsafe(
syncer::sync_ui_util::kDispatchEvent,
base::Value(syncer::sync_ui_util::kOnReceivedListOfTypes), event_details);
@@ -211,7 +211,7 @@ void SyncInternalsMessageHandler::EmitCounterUpdate(
std::unique_ptr<base::DictionaryValue> details(new base::DictionaryValue());
details->SetString(syncer::sync_ui_util::kModelType, ModelTypeToString(type));
details->SetString(syncer::sync_ui_util::kCounterType, counter_type);
- details->Set(syncer::sync_ui_util::kCounters, value.release());
+ details->Set(syncer::sync_ui_util::kCounters, std::move(value));
web_ui()->CallJavascriptFunctionUnsafe(
syncer::sync_ui_util::kDispatchEvent,
base::Value(syncer::sync_ui_util::kOnCountersUpdated), *details);

Powered by Google App Engine
This is Rietveld 408576698