Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7752)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/prerender/prerender_history.h ('K') | « chrome/browser/themes/theme_syncable_service_unittest.cc ('k') | chrome/browser/ui/webui/sync_internals_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc
diff --git a/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc b/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc
index 4d1793407c5173e9ef2cc3fe54078a70cedeb573..0715a734ad221270010c4b6e8d12981531f5133e 100644
--- a/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc
+++ b/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc
@@ -19,7 +19,7 @@ TEST(LocalStateUiTest, FilterPrefs) {
base::DictionaryValue prefs;
for (const std::string& key : all_pref_keys) {
- prefs.Set(key, new base::Value(key + "_value"));
+ prefs.SetString(key, key + "_value");
}
internal::FilterPrefs(prefixes, &prefs);
« chrome/browser/prerender/prerender_history.h ('K') | « chrome/browser/themes/theme_syncable_service_unittest.cc ('k') | chrome/browser/ui/webui/sync_internals_message_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698