Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: chrome/common/custom_handlers/protocol_handler.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/custom_handlers/protocol_handler.cc
diff --git a/chrome/common/custom_handlers/protocol_handler.cc b/chrome/common/custom_handlers/protocol_handler.cc
index 0990f48d562eacc767e1c18760505b9c681f8055..85749b3ff2d7262ce9aa6cb67034b7b90ed58f68 100644
--- a/chrome/common/custom_handlers/protocol_handler.cc
+++ b/chrome/common/custom_handlers/protocol_handler.cc
@@ -61,8 +61,8 @@ GURL ProtocolHandler::TranslateUrl(const GURL& url) const {
std::unique_ptr<base::DictionaryValue> ProtocolHandler::Encode() const {
auto d = base::MakeUnique<base::DictionaryValue>();
- d->Set("protocol", new base::Value(protocol_));
- d->Set("url", new base::Value(url_.spec()));
+ d->SetString("protocol", protocol_);
+ d->SetString("url", url_.spec());
return d;
}

Powered by Google App Engine
This is Rietveld 408576698