Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chrome/browser/themes/theme_syncable_service_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/themes/theme_syncable_service_unittest.cc
diff --git a/chrome/browser/themes/theme_syncable_service_unittest.cc b/chrome/browser/themes/theme_syncable_service_unittest.cc
index 3749a44cb81112f2dbf98b333a5e1e467d0b3cfd..a7cec612ea68b1cdcba9ae9c1c0056ecd1bd9106 100644
--- a/chrome/browser/themes/theme_syncable_service_unittest.cc
+++ b/chrome/browser/themes/theme_syncable_service_unittest.cc
@@ -12,6 +12,7 @@
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "base/time/time.h"
+#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/test_extension_system.h"
@@ -140,7 +141,8 @@ scoped_refptr<extensions::Extension> MakeThemeExtension(
const string& update_url) {
base::DictionaryValue source;
source.SetString(extensions::manifest_keys::kName, name);
- source.Set(extensions::manifest_keys::kTheme, new base::DictionaryValue());
+ source.Set(extensions::manifest_keys::kTheme,
+ base::MakeUnique<base::DictionaryValue>());
source.SetString(extensions::manifest_keys::kUpdateURL, update_url);
source.SetString(extensions::manifest_keys::kVersion, "0.0.0.0");
string error;

Powered by Google App Engine
This is Rietveld 408576698