Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
index deac6454853852667200f695e4ae0e922a948e61..98508f2892735e546de7e84898dcbe546644a5bd 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
@@ -62,7 +62,8 @@ Network.NetworkLogView = class extends UI.VBox {
*/
function updateRowHeight() {
/** @type {number} */
- this._rowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
+ this._rawRowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
allada 2017/05/16 21:40:06 Lets also turn the this._networkLogLargeRowsSettin
allada 2017/05/16 21:40:06 To help with removing @unrestricted lets define th
pfeldman 2017/05/16 22:34:16 Done.
pfeldman 2017/05/16 22:34:16 Not a great idea, the setting is the large/small,
+ this._updateRowHeight();
}
updateRowHeight.call(this);
@@ -369,6 +370,10 @@ Network.NetworkLogView = class extends UI.VBox {
this._invalidateAllItems();
}
+ _updateRowHeight() {
+ this._rowHeight = Math.floor(this._rawRowHeight * window.devicePixelRatio) / window.devicePixelRatio;
+ }
+
/**
* @param {!SDK.NetworkRequest} request
* @return {?Network.NetworkRequestNode}
@@ -798,6 +803,13 @@ Network.NetworkLogView = class extends UI.VBox {
}
/**
+ * @override
+ */
+ onResize() {
+ this._updateRowHeight();
+ }
+
+ /**
* @return {!Array<!Network.NetworkNode>}
*/
flatNodesList() {

Powered by Google App Engine
This is Rietveld 408576698