DevTools: fix network grid scroll to bottom, render group node frame icon.

DevTools: fix network grid scroll to bottom, render group node frame icon.

Review-Url: https://codereview.chromium.org/2887923002
Cr-Commit-Position: refs/heads/master@{#472374}
Committed: https://chromium.googlesource.com/chromium/src/+/9e124b1da54a26806df1446363817e901df3953c

[pfeldman, 2017-05-16 19:48:09]

pfeldman@chromium.org changed reviewers:
+ allada@chromium.org

[allada, 2017-05-16 21:40:07]

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:65:
this._rawRowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
To help with removing @unrestricted lets define this in the constructor.

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:65:
this._rawRowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
Lets also turn the this._networkLogLargeRowsSetting setting into the px size so
we can just query the size.

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:929:
this._timeCalculator.setWindow(null);
We need to add this here:

this._columns.setStickToBottom(true);

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:242:
this._waterfallColumn.setRowHeight(largeRows ? 41 : 21);
then here, we can just query what the size is here from the setting without 41
and 21 in two places.

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:29:
this._rawRowHeight = 0;
I think a short comment explaining the difference between these two would be
useful.

[pfeldman, 2017-05-16 22:34:16]

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:65:
this._rawRowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
On 2017/05/16 21:40:06, allada wrote:
> To help with removing @unrestricted lets define this in the constructor.

Done.

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:65:
this._rawRowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
On 2017/05/16 21:40:06, allada wrote:
> Lets also turn the this._networkLogLargeRowsSetting setting into the px size
so
> we can just query the size.

Not a great idea, the setting is the large/small, pixels should not be
configurable.

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:929:
this._timeCalculator.setWindow(null);
On 2017/05/16 21:40:06, allada wrote:
> We need to add this here:
> 
> this._columns.setStickToBottom(true);

You mean this._dataGrid.setStick... and below the removeChildren call below.

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2887923002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:29:
this._rawRowHeight = 0;
On 2017/05/16 21:40:07, allada wrote:
> I think a short comment explaining the difference between these two would be
> useful.

Done.

[pfeldman, 2017-05-16 22:34:36]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:35:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-05-16 22:50:59]

lgtm.

https://codereview.chromium.org/2887923002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2887923002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:947:
this._dataGrid.setStickToBottom(true);
Looks like this should be inside the above if. Not sure exactly why the if
exists, but might as well be safe here.

[pfeldman, 2017-05-16 23:10:19]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-05-16 23:10:19]

The patchset sent to the CQ was uploaded after l-g-t-m from allada@chromium.org
Link to the patchset: https://codereview.chromium.org/2887923002/#ps40001
(title: "dropped the datagrid check")

[commit-bot: I haz the power, 2017-05-16 23:11:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:27:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:27:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-05-17 06:52:30]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:53:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 07:50:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495003950399410,
"parent_rev": "bd34d5e9d74570f27d9c172120d91903399c70b6", "commit_rev":
"9e124b1da54a26806df1446363817e901df3953c"}

[commit-bot: I haz the power, 2017-05-17 07:50:20]

Description was changed from

==========
DevTools: fix network grid scroll to bottom, render group node frame icon.
==========

to

==========
DevTools: fix network grid scroll to bottom, render group node frame icon.

Review-Url: https://codereview.chromium.org/2887923002
Cr-Commit-Position: refs/heads/master@{#472374}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e124b1da54a26806df144636381...
==========

[commit-bot: I haz the power, 2017-05-17 07:50:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e124b1da54a26806df144636381...