Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 2d14c927f43f2ce9f99c5ec51dd5dd99f96e5af2..9e3cef25b811bf396fb72a3a23b7294252d59fd5 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -118,8 +118,7 @@ Network.NetworkLogViewColumns = class {
}
_setupWaterfall() {
- this._waterfallColumn =
- new Network.NetworkWaterfallColumn(this._networkLogView.rowHeight(), this._networkLogView.calculator());
+ this._waterfallColumn = new Network.NetworkWaterfallColumn(this._networkLogView.calculator());
this._waterfallColumn.element.addEventListener('contextmenu', handleContextMenu.bind(this));
this._waterfallColumn.element.addEventListener('mousewheel', this._onMouseWheel.bind(this, false), {passive: true});
@@ -235,11 +234,12 @@ Network.NetworkLogViewColumns = class {
_updateRowsSize() {
var largeRows = !!this._networkLogLargeRowsSetting.get();
+
this._dataGrid.element.classList.toggle('small', !largeRows);
this._dataGrid.scheduleUpdate();
this._waterfallScrollerWidthIsStale = true;
- this._waterfallColumn.setRowHeight(this._networkLogView.rowHeight());
+ this._waterfallColumn.setRowHeight(largeRows ? 41 : 21);
allada 2017/05/16 21:40:06 then here, we can just query what the size is here
this._waterfallScroller.classList.toggle('small', !largeRows);
this._waterfallHeaderElement.classList.toggle('small', !largeRows);
this._waterfallColumn.setHeaderHeight(this._waterfallScroller.offsetTop);

Powered by Google App Engine
This is Rietveld 408576698