third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js - Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('j') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

index da57062c4f2232c0c803d4ae65fcad3bdf44d5e3..007554264c570e3b4e7886f4f075084d862a75a7 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

@@ -76,8 +76,11 @@ Network.FrameGroupNode = class extends Network.NetworkGroupNode {

super.renderCell(cell, columnId);

if (columnId === 'name') {

var name = this.displayName();

- if (!this._productBadge)

+ if (!this._productBadge) {

this._productBadge = this.parentView().badgePool.badgeForFrame(this._frame);

+ this._productBadge.classList.add('network-frame-group-badge');

+ }

+ cell.appendChild(UI.Icon.create('largeicon-navigator-frame', 'network-frame-group-icon'));

cell.appendChild(this._productBadge);

cell.createTextChild(name);

cell.title = name;