DevTools: fix network grid scroll to bottom, render group node frame icon.

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 44 matching lines @@
     this._timeCalculator = new Network.NetworkTransferTimeCalculator();
     /** @type {!Network.NetworkTransferDurationCalculator} */
     this._durationCalculator = new Network.NetworkTransferDurationCalculator();
     this._calculator = this._timeCalculator;
 
     /**
      * @this {Network.NetworkLogView}
      */
     function updateRowHeight() {
       /** @type {number} */
-      this._rowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;
+      this._rawRowHeight = !!this._networkLogLargeRowsSetting.get() ? 41 : 21;

[allada, 2017/05/16 21:40:06]

Lets also turn the this._networkLogLargeRowsSetting setting into the px size so
we can just query the size.

[allada, 2017/05/16 21:40:06]

To help with removing @unrestricted lets define this in the constructor.

[pfeldman, 2017/05/16 22:34:16]

Done.

[pfeldman, 2017/05/16 22:34:16]

Not a great idea, the setting is the large/small, pixels should not be
configurable.

+      this._updateRowHeight();
     }
     updateRowHeight.call(this);
 
     this._columns = new Network.NetworkLogViewColumns(
         this, this._timeCalculator, this._durationCalculator, networkLogLargeRowsSetting);
 
     /** @type {!Map.<string, !Network.NetworkRequestNode>} */
     this._nodesByRequestId = new Map();
     /** @type {!Object.<string, boolean>} */
     this._staleRequestIds = {};
@@ skipping 286 matching lines @@
    * @param {?string} groupKey
    */
   _setGrouping(groupKey) {
     var groupLookup = groupKey ? this._groupLookups.get(groupKey) || null : null;
     this._activeGroupLookup = groupLookup;
     if (groupLookup)
       groupLookup.reset();
     this._invalidateAllItems();
   }
 
+  _updateRowHeight() {
+    this._rowHeight = Math.floor(this._rawRowHeight * window.devicePixelRatio) / window.devicePixelRatio;
+  }
+
   /**
    * @param {!SDK.NetworkRequest} request
    * @return {?Network.NetworkRequestNode}
    */
   nodeForRequest(request) {
     return this._nodesByRequestId.get(request.requestId());
   }
 
   /**
    * @return {number}
@@ skipping 409 matching lines @@
   }
 
   /**
    * @override
    */
   willHide() {
     this._columns.willHide();
   }
 
   /**
+   * @override
+   */
+  onResize() {
+    this._updateRowHeight();
+  }
+
+  /**
    * @return {!Array<!Network.NetworkNode>}
    */
   flatNodesList() {
     return this._dataGrid.rootNode().flatChildren();
   }
 
   stylesChanged() {
     this._columns.scheduleRefresh();
   }
 
@@ skipping 96 matching lines @@
     this.dispatchEventToListeners(Network.NetworkLogView.Events.RequestSelected, null);
 
     this._clearSearchMatchedList();
 
     this._setHoveredNode(null);
     this._columns.reset();
 
     this._timeFilter = null;
     this._calculator.reset();
 
     this._timeCalculator.setWindow(null);

[allada, 2017/05/16 21:40:06]

We need to add this here:

this._columns.setStickToBottom(true);

[pfeldman, 2017/05/16 22:34:16]

You mean this._dataGrid.setStick... and below the removeChildren call below.

     this.linkifier.reset();
     this.badgePool.reset();
 
     if (this._activeGroupLookup)
       this._activeGroupLookup.reset();
     this._nodesByRequestId.clear();
     this._staleRequestIds = {};
     this._resetSuggestionBuilder();
 
     this._mainRequestLoadTime = -1;
@@ skipping 890 matching lines @@
 
 Network.GroupLookupInterface.prototype = {
   /**
    * @param {!SDK.NetworkRequest} request
    * @return {?Network.NetworkGroupNode}
    */
   groupNodeForRequest: function(request) {},
 
   reset: function() {}
 };