Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkFrameGrouper.js

Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @implements {Network.GroupLookupInterface} 6 * @implements {Network.GroupLookupInterface}
7 */ 7 */
8 Network.NetworkFrameGrouper = class { 8 Network.NetworkFrameGrouper = class {
9 /** 9 /**
10 * @param {!Network.NetworkLogView} parentView 10 * @param {!Network.NetworkLogView} parentView
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 /** 70 /**
71 * @override 71 * @override
72 * @param {!Element} cell 72 * @param {!Element} cell
73 * @param {string} columnId 73 * @param {string} columnId
74 */ 74 */
75 renderCell(cell, columnId) { 75 renderCell(cell, columnId) {
76 super.renderCell(cell, columnId); 76 super.renderCell(cell, columnId);
77 if (columnId === 'name') { 77 if (columnId === 'name') {
78 var name = this.displayName(); 78 var name = this.displayName();
79 if (!this._productBadge) 79 if (!this._productBadge) {
80 this._productBadge = this.parentView().badgePool.badgeForFrame(this._fra me); 80 this._productBadge = this.parentView().badgePool.badgeForFrame(this._fra me);
81 this._productBadge.classList.add('network-frame-group-badge');
82 }
83 cell.appendChild(UI.Icon.create('largeicon-navigator-frame', 'network-fram e-group-icon'));
81 cell.appendChild(this._productBadge); 84 cell.appendChild(this._productBadge);
82 cell.createTextChild(name); 85 cell.createTextChild(name);
83 cell.title = name; 86 cell.title = name;
84 } 87 }
85 } 88 }
86 }; 89 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698