Reland: Handle long press in PDF documents.

Reland: Handle long press in PDF documents.

This Cl updates the touch handlers for PDF documents to better support
long press. The long press context menu is suppressed and the wonder
under the press is of sufficient time.

This attempt disables the test which seems to fail on certain bots.

BUG=chromium:490184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

PRIOR REVIEWS:
> Review-Url: https://codereview.chromium.org/2855953003
> Revert Review-Url: https://codereview.chromium.org/2864603006
> Reland Review-Url: https://codereview.chromium.org/2861383003

Review-Url: https://codereview.chromium.org/2887913002
Cr-Commit-Position: refs/heads/master@{#472451}
Committed: https://chromium.googlesource.com/chromium/src/+/781747b0aa041e426b6446bd49c11f9710b31c9d

[dsinclair, 2017-05-16 20:18:51]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org

[dsinclair, 2017-05-16 20:18:51]

PTAL. I'm not sure how else to deal with this. It works on the machines I've
tried it on, the test passes on the try bots. It's just some of the waterfall
bots that break.

[Lei Zhang, 2017-05-17 08:36:39]

lgtm

https://codereview.chromium.org/2887913002/diff/20001/chrome/test/data/pdf/to...
File chrome/test/data/pdf/touch_handling_test.js (right):

https://codereview.chromium.org/2887913002/diff/20001/chrome/test/data/pdf/to...
chrome/test/data/pdf/touch_handling_test.js:55: // Test long press selects word.
This test flakes out on some bots.
Reference a bug?

https://codereview.chromium.org/2887913002/diff/20001/chrome/test/data/pdf/to...
chrome/test/data/pdf/touch_handling_test.js:58: //function
testLongPressSelectsText() {
Do you need one more space here and below?

[dsinclair, 2017-05-17 13:19:29]

https://codereview.chromium.org/2887913002/diff/20001/chrome/test/data/pdf/to...
File chrome/test/data/pdf/touch_handling_test.js (right):

https://codereview.chromium.org/2887913002/diff/20001/chrome/test/data/pdf/to...
chrome/test/data/pdf/touch_handling_test.js:55: // Test long press selects word.
This test flakes out on some bots.
On 2017/05/17 08:36:38, Lei Zhang wrote:
> Reference a bug?

Done.

https://codereview.chromium.org/2887913002/diff/20001/chrome/test/data/pdf/to...
chrome/test/data/pdf/touch_handling_test.js:58: //function
testLongPressSelectsText() {
On 2017/05/17 08:36:38, Lei Zhang wrote:
> Do you need one more space here and below?

Done. Was trying to avoid re-wrapping line 63.

[dsinclair, 2017-05-17 13:19:33]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-05-17 13:19:34]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2887913002/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2017-05-17 13:19:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 14:46:07]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495027173799360,
"parent_rev": "e166639c22398d2c3cda8c437198e0cb1ab52bc6", "commit_rev":
"781747b0aa041e426b6446bd49c11f9710b31c9d"}

[commit-bot: I haz the power, 2017-05-17 14:46:22]

Description was changed from

==========
Reland: Handle long press in PDF documents.

This Cl updates the touch handlers for PDF documents to better support
long press. The long press context menu is suppressed and the wonder
under the press is of sufficient time.

This attempt disables the test which seems to fail on certain bots.

BUG=chromium:490184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

PRIOR REVIEWS:
> Review-Url: https://codereview.chromium.org/2855953003
> Revert Review-Url: https://codereview.chromium.org/2864603006
> Reland Review-Url: https://codereview.chromium.org/2861383003
==========

to

==========
Reland: Handle long press in PDF documents.

This Cl updates the touch handlers for PDF documents to better support
long press. The long press context menu is suppressed and the wonder
under the press is of sufficient time.

This attempt disables the test which seems to fail on certain bots.

BUG=chromium:490184
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

PRIOR REVIEWS:
> Review-Url: https://codereview.chromium.org/2855953003
> Revert Review-Url: https://codereview.chromium.org/2864603006
> Reland Review-Url: https://codereview.chromium.org/2861383003

Review-Url: https://codereview.chromium.org/2887913002
Cr-Commit-Position: refs/heads/master@{#472451}
Committed:
https://chromium.googlesource.com/chromium/src/+/781747b0aa041e426b6446bd49c1...
==========

[commit-bot: I haz the power, 2017-05-17 14:46:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/781747b0aa041e426b6446bd49c1...