DescriptionRevert of Handle long press in PDF documents. (patchset #8 id:140001 of https://codereview.chromium.org/2855953003/ )
Reason for revert:
Breaks Mac bots. See https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZlNTE2NTNlMDZkMTc0MGI1ZmU3MGIzZWY5YzJlNmZlOTU5ZTM5NjgM
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/12082
[ RUN ] PDFExtensionTest.TouchHandling
[21973:14375:0506/122844.659425:WARNING:notification_platform_bridge_mac.mm(493)] AlertNotificationService: XPC connection invalidated.
2017-05-06 12:28:44.811 browser_tests[21973:153848] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fb0f2d756b0>. Break on NSLog to debug.
2017-05-06 12:28:44.812 browser_tests[21973:153848] Call stack:
(
"+callStackSymbols disabled for performance reasons"
)
[21973:87319:0506/122847.139773:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
[21973:35843:0506/122850.985727:ERROR:service_manager.cc(137)] Connection InterfaceProviderSpec prevented service: content_plugin from binding interface: memory_instrumentation::mojom::Coordinator exposed by: content_browser
[21973:775:0506/122851.245843:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuSingleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[21973:775:0506/122851.307976:INFO:CONSOLE(0)] "[SUCCESS] testContextMenuDoubleTouch", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[21973:775:0506/122851.669523:INFO:CONSOLE(0)] "[SUCCESS] testLongPressSelectsText", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[21973:775:0506/122851.674726:INFO:CONSOLE(0)] "[FAIL] testLongPressSelectsText: API Test Error in testLongPressSelectsText
Actual:
Expected: some
Error
at Object.handleRequest (extensions::binding:63:27)
at Object.<anonymous> (extensions::binding:422:32)
at Object.<anonymous> (extensions::test:215:18)
at Object.handleRequest (extensions::binding:63:27)
at Object.<anonymous> (extensions::binding:422:32)
at <anonymous>:192:21
at safeFunctionApply (extensions::test:260:26)
at PDFScriptingAPI.selectedTextCallback_ (extensions::test:285:18)
at PDFScriptingAPI.<anonymous> (chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/pdf_scripting_api.js:81:16)", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (0)
[21973:775:0506/122851.676537:INFO:CONSOLE(263)] "Uncaught chrome.test.failure", source: extensions::test (263)
../../chrome/browser/pdf/pdf_extension_test.cc:165: Failure
Failed
Failed 1 of 3 tests
[ FAILED ] PDFExtensionTest.TouchHandling, where TypeParam = and GetParam() = (8405 ms)
Original issue's description:
> Handle long press in PDF documents.
>
> This Cl updates the touch handlers for PDF documents to better support
> long press. The long press context menu is suppressed and the wonder
> under the press is of sufficient time.
>
> BUG=chromium:490184
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2855953003
> Cr-Commit-Position: refs/heads/master@{#469849}
> Committed: https://chromium.googlesource.com/chromium/src/+/6e51653e06d1740b5fe70b3ef9c2e6fe959e3968
TBR=mcnee@chromium.org,thestig@chromium.org,dsinclair@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:490184
Review-Url: https://codereview.chromium.org/2864603006
Cr-Commit-Position: refs/heads/master@{#469890}
Committed: https://chromium.googlesource.com/chromium/src/+/294c45c4ee187d3f50814008c99541ec222d332e
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|