Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2861383003: Reland: Handle long press in PDF documents. (Closed)

Created:
3 years, 7 months ago by dsinclair
Modified:
3 years, 7 months ago
Reviewers:
Lei Zhang, Kevin McNee
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Handle long press in PDF documents. This Cl updates the touch handlers for PDF documents to better support long press. The long press context menu is suppressed and the wonder under the press is of sufficient time. BUG=chromium:490184 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation PRIOR REVIEWS: > Review-Url: https://codereview.chromium.org/2855953003 > Revert Review-Url: https://codereview.chromium.org/2864603006 Review-Url: https://codereview.chromium.org/2861383003 Cr-Commit-Position: refs/heads/master@{#471915} Committed: https://chromium.googlesource.com/chromium/src/+/c40173af073adb3b81cc4de1e8e8467b48b384df

Patch Set 1 : Original reverted CL. #

Patch Set 2 : Rebase to master #

Patch Set 3 : Increase touch timeout #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -51 lines) Patch
M chrome/browser/pdf/pdf_extension_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/gesture_detector.js View 3 chunks +19 lines, -8 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/test/data/pdf/gesture_detector_test.js View 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/test/data/pdf/touch_handling_test.js View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.h View 3 chunks +4 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 7 chunks +52 lines, -25 lines 0 comments Download
M pdf/pdf_engine.h View 2 chunks +7 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 5 chunks +12 lines, -7 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 6 chunks +61 lines, -9 lines 0 comments Download
M pdf/preview_mode_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/preview_mode_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
dsinclair
PTAL. I tried on windows and mac and can't repro the crash. I'm guessing it's ...
3 years, 7 months ago (2017-05-11 16:40:28 UTC) #2
dsinclair
ping.
3 years, 7 months ago (2017-05-15 13:32:50 UTC) #7
Kevin McNee
non-owner, but still lgtm
3 years, 7 months ago (2017-05-15 14:42:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861383003/60001
3 years, 7 months ago (2017-05-15 14:48:10 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-15 14:48:12 UTC) #12
Lei Zhang
lgtm
3 years, 7 months ago (2017-05-15 18:37:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861383003/60001
3 years, 7 months ago (2017-05-15 18:39:33 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c40173af073adb3b81cc4de1e8e8467b48b384df
3 years, 7 months ago (2017-05-15 21:55:54 UTC) #18
findit-for-me
Findit (https://goo.gl/kROfz5) identified this CL at revision 471915 as the culprit for failures in the ...
3 years, 7 months ago (2017-05-15 23:25:05 UTC) #19
afakhry
3 years, 7 months ago (2017-05-15 23:56:09 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2886623002/ by afakhry@chromium.org.

The reason for reverting is: Causes failure in browser_tests on the Linux
ChromiumOS Tests builder (PDFExtensionTest.TouchHandling).
BUG=722625.

Powered by Google App Engine
This is Rietveld 408576698