[DevTools] update decorations when there is no pending possibleBreakpoints

[DevTools] update decorations when there is no pending possibleBreakpoints

Currently when user clicks by gutter:
- we add fake breakpoint and request inline breakpoints,
- as soon as breakpoint resolved we remove fake breakpoint, schedule removing of inline breakpoints and request inline breakpoints again.
- as soon as possibleBreakpoints request is fulfilled we render inline decorations again.

As result user can see blinking of inline breakpoints. To solve this issue with this CL we update inline decorations only when all pending possibleBreakpoints requests for current line are fulfilled.

BUG=none
R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2887903002
Cr-Commit-Position: refs/heads/master@{#472499}
Committed: https://chromium.googlesource.com/chromium/src/+/bd6ab69408c03fcb7c9efaddac139049e9e2e54c

[kozy, 2017-05-16 18:44:30]

Pavel, please take a look.

[kozy, 2017-05-16 20:20:36]

Description was changed from

==========
[DevTools] update decorations when there is no pending possibleBreakpoints

Currently when user clicks by gutter:
- we add fake breakpoint and request inline breakpoints,
- as soon as breakpoint resolved we remove fake breakpoint, schedule removing of
inline breakpoints and request inline breakpoints again.
- as soon as possibleBreakpoints request is fulfilled we render inline
decorations again.

As result user can see blinking of inline breakpoints. To solve this issue with
this CL we update inline decorations only when all pending possibleBreakpoints
requests for current line are fulfilled.

BUG=none
R=pfeldman@chromium.org
==========

to

==========
[DevTools] update decorations when there is no pending possibleBreakpoints

Currently when user clicks by gutter:
- we add fake breakpoint and request inline breakpoints,
- as soon as breakpoint resolved we remove fake breakpoint, schedule removing of
inline breakpoints and request inline breakpoints again.
- as soon as possibleBreakpoints request is fulfilled we render inline
decorations again.

As result user can see blinking of inline breakpoints. To solve this issue with
this CL we update inline decorations only when all pending possibleBreakpoints
requests for current line are fulfilled.

BUG=none
R=pfeldman@chromium.org
==========

[kozy, 2017-05-16 20:20:36]

kozyatinskiy@chromium.org changed reviewers:
+ dgozman@chromium.org

[kozy, 2017-05-16 20:20:48]

Dmitry, please take a look.

[dgozman, 2017-05-16 22:54:20]

lgtm

https://codereview.chromium.org/2887903002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2887903002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:1268:
this._didAddInlineDecorationsForTest(updateWasScheduled);
Should we remove this flag?

[kozy, 2017-05-16 23:23:11]

On 2017/05/16 22:54:20, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2887903002/diff/1/third_party/WebKit/Source/d...
> File
> third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
> (right):
> 
>
https://codereview.chromium.org/2887903002/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:1268:
> this._didAddInlineDecorationsForTest(updateWasScheduled);
> Should we remove this flag?

We should remove more than this flag :) Removed.

[kozy, 2017-05-16 23:23:15]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-05-16 23:23:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2887903002/#ps20001
(title: "better tests")

[commit-bot: I haz the power, 2017-05-16 23:24:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:46:21]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kozy, 2017-05-17 15:39:25]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:40:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:13:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495035565421320,
"parent_rev": "88d98e2b9d1999ca8b65bc516e00b87d86374cb3", "commit_rev":
"bd6ab69408c03fcb7c9efaddac139049e9e2e54c"}

[commit-bot: I haz the power, 2017-05-17 18:13:45]

Description was changed from

==========
[DevTools] update decorations when there is no pending possibleBreakpoints

Currently when user clicks by gutter:
- we add fake breakpoint and request inline breakpoints,
- as soon as breakpoint resolved we remove fake breakpoint, schedule removing of
inline breakpoints and request inline breakpoints again.
- as soon as possibleBreakpoints request is fulfilled we render inline
decorations again.

As result user can see blinking of inline breakpoints. To solve this issue with
this CL we update inline decorations only when all pending possibleBreakpoints
requests for current line are fulfilled.

BUG=none
R=pfeldman@chromium.org
==========

to

==========
[DevTools] update decorations when there is no pending possibleBreakpoints

Currently when user clicks by gutter:
- we add fake breakpoint and request inline breakpoints,
- as soon as breakpoint resolved we remove fake breakpoint, schedule removing of
inline breakpoints and request inline breakpoints again.
- as soon as possibleBreakpoints request is fulfilled we render inline
decorations again.

As result user can see blinking of inline breakpoints. To solve this issue with
this CL we update inline decorations only when all pending possibleBreakpoints
requests for current line are fulfilled.

BUG=none
R=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2887903002
Cr-Commit-Position: refs/heads/master@{#472499}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd6ab69408c03fcb7c9efaddac13...
==========

[commit-bot: I haz the power, 2017-05-17 18:13:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bd6ab69408c03fcb7c9efaddac13...