Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2889853002: [DevTools] breakpoint manager should be ready for location from different model (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] breakpoint manager should be ready for location from different model There is no gurantees for debugger model of location returned from uiLocationToRawLocation call. BreakpointManager should be ready. BUG=chromium:722715, chromium:721993 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2889853002 Cr-Commit-Position: refs/heads/master@{#472648} Committed: https://chromium.googlesource.com/chromium/src/+/f8bc6f196aa3279a2480d224a1f678a6680ceeef

Patch Set 1 #

Patch Set 2 : added a test #

Patch Set 3 : rebased #

Messages

Total messages: 16 (8 generated)
kozy
Dmitry, please take a look. Let's prepare it first and later figure out better solution ...
3 years, 7 months ago (2017-05-16 23:42:54 UTC) #1
dgozman
Let's add a test. lgtm
3 years, 7 months ago (2017-05-16 23:54:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889853002/40001
3 years, 7 months ago (2017-05-17 18:25:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/457830)
3 years, 7 months ago (2017-05-17 20:35:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889853002/40001
3 years, 7 months ago (2017-05-17 21:19:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/458239)
3 years, 7 months ago (2017-05-18 00:06:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889853002/40001
3 years, 7 months ago (2017-05-18 02:05:44 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 03:47:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f8bc6f196aa3279a2480d224a1f6...

Powered by Google App Engine
This is Rietveld 408576698