Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

Issue 2887903002: [DevTools] update decorations when there is no pending possibleBreakpoints (Closed)
Patch Set: better tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/set-breakpoint.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
index 087b3374755fe5d862eca763fd49119b55aebf13..560682d2979f6830cddfa14729b83e5d572d4688 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
@@ -654,26 +654,8 @@ InspectorTest.evaluateOnCurrentCallFrame = function(code)
return new Promise(succ => InspectorTest.debuggerModel.evaluateOnSelectedCallFrame(code, "console", false, true, false, false, InspectorTest.safeWrap(succ)));
}
-InspectorTest.prepareSourceFrameForBreakpointTest = function(sourceFrame)
-{
- var symbol = Symbol('waitedDecorations');
- sourceFrame[symbol] = 0;
- InspectorTest.addSniffer(sourceFrame.__proto__, "_willAddInlineDecorationsForTest", () => sourceFrame[symbol]++, true);
- InspectorTest.addSniffer(sourceFrame.__proto__, "_didAddInlineDecorationsForTest", (updateWasScheduled) => {
- sourceFrame[symbol]--;
- if (!updateWasScheduled)
- sourceFrame._breakpointDecorationsUpdatedForTest();
- }, true);
- sourceFrame._waitingForPossibleLocationsForTest = () => !!sourceFrame[symbol];
-}
-
InspectorTest.waitJavaScriptSourceFrameBreakpoints = function(sourceFrame, inline)
{
- if (!sourceFrame._waitingForPossibleLocationsForTest) {
- InspectorTest.addResult("Error: source frame should be prepared with InspectorTest.prepareSourceFrameForBreakpointTest function.");
- InspectorTest.completeTest();
- return;
- }
return waitUpdate().then(checkIfReady);
function waitUpdate()
{
@@ -681,8 +663,6 @@ InspectorTest.waitJavaScriptSourceFrameBreakpoints = function(sourceFrame, inlin
}
function checkIfReady()
{
- if (sourceFrame._waitingForPossibleLocationsForTest())
- return waitUpdate().then(checkIfReady);
for (var breakpoint of Bindings.breakpointManager._allBreakpoints()) {
if (breakpoint._fakePrimaryLocation && breakpoint.enabled())
return waitUpdate().then(checkIfReady);
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/set-breakpoint.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698