Identify MostVisited by item instead of URL

Identify MostVisited by item instead of URL

The Most Visited items displayed by the Collection View cannot be identified by
their URL as the UI layer cannot know about them.
When a favicon of a Most Visited is updated, the ContentSuggestionsDataSource
directly passes the item instead of the URL.

BUG=707754, 720271
Review-Url: https://codereview.chromium.org/2888533002
Cr-Commit-Position: refs/heads/master@{#472466}
Committed: https://chromium.googlesource.com/chromium/src/+/91228d6c2af35f799237940bd218ab5df9d18008

[gambard, 2017-05-16 12:15:56]

gambard@chromium.org changed reviewers:
+ jif@chromium.org

[gambard, 2017-05-16 12:15:56]

PTAL.

[jif, 2017-05-17 13:13:28]

lgtm

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/mediator_util.h (right):

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/mediator_util.h:63: // Converts a
ntp_snippets::ContentSuggestion to an adapted CollectionViewItem
s/ntp_snippets::ContentSuggestion/ntp_tiles::NTPTile/ ?

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:451:
// Sets the attributes of |item| to |attributes| and reconfigure it.
and reconfigures

[gambard, 2017-05-17 14:13:32]

Thanks!

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/content_suggestions/mediator_util.h (right):

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/content_suggestions/mediator_util.h:63: // Converts a
ntp_snippets::ContentSuggestion to an adapted CollectionViewItem
On 2017/05/17 13:13:28, jif wrote:
> s/ntp_snippets::ContentSuggestion/ntp_tiles::NTPTile/ ?

Done.

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/ui/c...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
(right):

https://codereview.chromium.org/2888533002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:451:
// Sets the attributes of |item| to |attributes| and reconfigure it.
On 2017/05/17 13:13:28, jif wrote:
> and reconfigures

Done.

[gambard, 2017-05-17 14:13:35]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-05-17 14:13:35]

The patchset sent to the CQ was uploaded after l-g-t-m from jif@chromium.org
Link to the patchset: https://codereview.chromium.org/2888533002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2017-05-17 14:13:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 16:11:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495030415297660,
"parent_rev": "888a72fe40428af01d6b47d0891de462e6062f2c", "commit_rev":
"91228d6c2af35f799237940bd218ab5df9d18008"}

[commit-bot: I haz the power, 2017-05-17 16:11:30]

Description was changed from

==========
Identify MostVisited by item instead of URL

The Most Visited items displayed by the Collection View cannot be identified by
their URL as the UI layer cannot know about them.
When a favicon of a Most Visited is updated, the ContentSuggestionsDataSource
directly passes the item instead of the URL.

BUG=707754, 720271
==========

to

==========
Identify MostVisited by item instead of URL

The Most Visited items displayed by the Collection View cannot be identified by
their URL as the UI layer cannot know about them.
When a favicon of a Most Visited is updated, the ContentSuggestionsDataSource
directly passes the item instead of the URL.

BUG=707754, 720271

Review-Url: https://codereview.chromium.org/2888533002
Cr-Commit-Position: refs/heads/master@{#472466}
Committed:
https://chromium.googlesource.com/chromium/src/+/91228d6c2af35f799237940bd218...
==========

[commit-bot: I haz the power, 2017-05-17 16:11:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/91228d6c2af35f799237940bd218...