Generate StyleRareInheritedData in ComputedStyleBase.

Generate StyleRareInheritedData in ComputedStyleBase.

This patch generates StyleRareInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/4ffa0198d36f4e0ff56ee0fc3b12619a/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2887333003
Cr-Commit-Position: refs/heads/master@{#474510}
Committed: https://chromium.googlesource.com/chromium/src/+/e66a502427e1744331aef5edf65c417dc244ae0c

[shend, 2017-05-19 06:55:08]

Description was changed from

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase.

All fields are generated as storage_only in this patch, but future patches
may change that.

BUG=628043
==========

to

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/fec27d1c6f59cd3ab58bca7bdfe2897f/revisions

BUG=628043
==========

[shend, 2017-05-21 23:32:31]

Description was changed from

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/fec27d1c6f59cd3ab58bca7bdfe2897f/revisions

BUG=628043
==========

to

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/fec27d1c6f59cd3ab58bca7bdfe2897f/revisions

BUG=628043
==========

[shend, 2017-05-21 23:38:13]

Description was changed from

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/fec27d1c6f59cd3ab58bca7bdfe2897f/revisions

BUG=628043
==========

to

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/b262325f1a53ed80daa199ae33e9088a/revisions

BUG=628043
==========

[shend, 2017-05-21 23:49:49]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-21 23:49:50]

Hi Naina, PTAL

[shend, 2017-05-21 23:50:53]

Description was changed from

==========
Generate StyleInheritedData in ComputedStyleBase.

This patch generates StyleInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/b262325f1a53ed80daa199ae33e9088a/revisions

BUG=628043
==========

to

==========
Generate StyleRareInheritedData in ComputedStyleBase.

This patch generates StyleRareInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/b262325f1a53ed80daa199ae33e9088a/revisions

BUG=628043
==========

[nainar, 2017-05-21 23:59:35]

lgtm with nits.

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
(right):

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:14:
#include "core/layout/LayoutTheme.h"
Why did you have to add this by hand?

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl
(right):

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl:66: {% macro
compare(is_pointer_type, expr, other_name) %}
The comparisons in the generated diff attached seem to be over indented.
Probably has to do with this.

[shend, 2017-05-22 00:19:04]

Description was changed from

==========
Generate StyleRareInheritedData in ComputedStyleBase.

This patch generates StyleRareInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/b262325f1a53ed80daa199ae33e9088a/revisions

BUG=628043
==========

to

==========
Generate StyleRareInheritedData in ComputedStyleBase.

This patch generates StyleRareInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/4ffa0198d36f4e0ff56ee0fc3b12619a/revisions

BUG=628043
==========

[shend, 2017-05-22 00:19:18]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-22 00:19:19]

Hi Eddy, PTAL

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
(right):

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:14:
#include "core/layout/LayoutTheme.h"
On 2017/05/21 at 23:59:35, nainar wrote:
> Why did you have to add this by hand?

The default value of one of the fields is a static method on LayoutTheme. The
generator won't know where to include LayoutTheme from. Ideally there will be a
better way in the future.

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl
(right):

https://codereview.chromium.org/2887333003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl:66: {% macro
compare(is_pointer_type, expr, other_name) %}
On 2017/05/21 at 23:59:35, nainar wrote:
> The comparisons in the generated diff attached seem to be over indented.
Probably has to do with this.

Done.

[meade_UTC10, 2017-05-23 04:49:52]

lgtm

https://codereview.chromium.org/2887333003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2887333003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:113:
pointer_type_name: Name of the pointer type that wraps this field (e.g. RefPtr).
nit: Should it be "wrapper_pointer_name" or similar? "type" seems very
overloaded as a keyword and doesn't have a lot of meaning...

[shend, 2017-05-23 23:13:46]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 23:17:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-23 23:20:58]

https://codereview.chromium.org/2887333003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_computed_style_base.py
(right):

https://codereview.chromium.org/2887333003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_computed_style_base.py:113:
pointer_type_name: Name of the pointer type that wraps this field (e.g. RefPtr).
On 2017/05/23 at 04:49:52, meade_UTC10 wrote:
> nit: Should it be "wrapper_pointer_name" or similar? "type" seems very
overloaded as a keyword and doesn't have a lot of meaning...

done.

[shend, 2017-05-23 23:51:53]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 23:52:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 05:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 05:38:44]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-24 07:10:46]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 07:11:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 07:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-24 07:18:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shend, 2017-05-24 22:53:12]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-24 22:54:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 01:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 01:13:33]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-25 01:16:19]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-25 01:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2887333003/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-25 01:17:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 01:24:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495674979852620,
"parent_rev": "eada8b93d4a46d1b6f0095c7f0bfad0954345fa4", "commit_rev":
"f8918d64d6a49e1b4ebd5ebcc6ae9a5e84cb598f"}

[commit-bot: I haz the power, 2017-05-25 01:24:32]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495674979852620,
"parent_rev": "9633bdae6c22b92251de820e4a114c1dda06bcea", "commit_rev":
"e66a502427e1744331aef5edf65c417dc244ae0c"}

[commit-bot: I haz the power, 2017-05-25 01:24:47]

Description was changed from

==========
Generate StyleRareInheritedData in ComputedStyleBase.

This patch generates StyleRareInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/4ffa0198d36f4e0ff56ee0fc3b12619a/revisions

BUG=628043
==========

to

==========
Generate StyleRareInheritedData in ComputedStyleBase.

This patch generates StyleRareInheritedData in ComputedStyleBase. Because some
fields are stored as smart pointers, we have to introduce a new parameter
in the JSON file called "pointer_type_name", which is the name of the
smart pointer type. As with the handwritten code, pointer fields are
compared using DataEquivalent, not ==.

All fields are generated as storage_only in this patch, but future patches
may change that.

Diff of generated files:
https://gist.github.com/darrnshn/4ffa0198d36f4e0ff56ee0fc3b12619a/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2887333003
Cr-Commit-Position: refs/heads/master@{#474510}
Committed:
https://chromium.googlesource.com/chromium/src/+/e66a502427e1744331aef5edf65c...
==========

[commit-bot: I haz the power, 2017-05-25 01:24:49]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/e66a502427e1744331aef5edf65c...