third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl - Issue 2887333003: Generate StyleRareInheritedData in ComputedStyleBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

Issue 2887333003: Generate StyleRareInheritedData in ComputedStyleBase. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | third_party/WebKit/Source/core/css/CSSProperties.json5 » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

index 3b62d0a290e0dd5805de69989ddd7a5d7e0daa5d..56d3f9db36dc79e88c04503199e9e0cd1cea6d1a 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

@@ -1,4 +1,4 @@

-{% from 'fields/field.tmpl' import encode, declare_storage %}

+{% from 'fields/field.tmpl' import encode, declare_storage, compare %}

{% from 'macros.tmpl' import print_if %}

{% macro define_field_group_class(group): -%}

class {{group.type_name}} : public RefCountedCopyable<{{group.type_name}}> {

@@ -13,7 +13,7 @@ class {{group.type_name}} : public RefCountedCopyable<{{group.type_name}}> {

bool operator==(const {{group.type_name}}& other) const {

return (

{% for field in group.fields %}

- {{field.name}} == other.{{field.name}}{{print_if(not loop.last, ' &&')}}

+ {{compare(field.wrapper_pointer_name, field.name, "other")}}{{print_if(not loop.last, ' &&')}}

{% endfor %}

);

}