Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issue 2895143002: Generate getters/setters for line-step-height. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for line-height-step. Currently, the line-height-step property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'primitive' field so that their getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/c7aa4490604c306177cacf258e2038f4/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2895143002 Cr-Commit-Position: refs/heads/master@{#474585} Committed: https://chromium.googlesource.com/chromium/src/+/da75ab7764c7e666793460ec09acacdf0dbb3172

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (17 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 23:25:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895143002/40001
3 years, 7 months ago (2017-05-25 06:25:47 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-25 06:25:49 UTC) #17
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-25 06:26:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2895143002/40001
3 years, 7 months ago (2017-05-25 06:28:30 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 06:33:14 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/da75ab7764c7e666793460ec09ac...

Powered by Google App Engine
This is Rietveld 408576698